lib.warn: Add NIX_ABORT_ON_WARN for call traces#140763
Merged
roberth merged 1 commit intoNixOS:masterfrom Oct 13, 2021
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Oct 6, 2021
infinisil
reviewed
Oct 6, 2021
lib/trivial.nix
Outdated
Member
There was a problem hiding this comment.
It doesn't behave exactly like builtins.trace, because this function requires a string, whereas builtins.trace works with arbitrary things to trace.
Member
Author
There was a problem hiding this comment.
I've clarified it, but left out the color, because we may want to change that to match Nix, which is switching to purple last time I checked.
infinisil
approved these changes
Oct 6, 2021
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
I think this is a great idea to implement something like this, I'd have liked this a couple times before
Member
|
Sounds good to merge after a squash |
roberth
force-pushed
the
abort-on-warn
branch
from
24bdb97 to
c9b7cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Finding the cause of a warning isn't always easy.
Printing a stack trace on every
builtins.traceisn't feasible in Nix itself, so this is the next best thing, even if you can only find the first warning.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)