Skip to content

gnomeExtensions.unite: remove manually packaging and use extension override#140298

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
rhoriguchi:gnomeExtensions.unite
Oct 3, 2021
Merged

gnomeExtensions.unite: remove manually packaging and use extension override#140298
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
rhoriguchi:gnomeExtensions.unite

Conversation

@rhoriguchi
Copy link
Copy Markdown
Contributor

@rhoriguchi rhoriguchi commented Oct 2, 2021

Motivation for this change

Depends on #140285. Since the current version in extensions.json is lower than the packed one.

Use the new override logic from #137131 to add buildInputs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 2, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 2, 2021
@mweinelt mweinelt requested a review from piegamesde October 2, 2021 16:33
@piegamesde
Copy link
Copy Markdown
Member

Looks great, thank you. Would you mind also adding yourself to the maintainers of that package using the override?

@rhoriguchi
Copy link
Copy Markdown
Contributor Author

Looks great, thank you. Would you mind also adding yourself to the maintainers of that package using the override?

Sure, I've added myself.

@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 3, 2021
@SuperSandro2000 SuperSandro2000 merged commit 375e8be into NixOS:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants