gnomeExtensions.unite: remove manually packaging and use extension override#140298
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Oct 3, 2021
rhoriguchi:gnomeExtensions.unite
Merged
gnomeExtensions.unite: remove manually packaging and use extension override#140298SuperSandro2000 merged 1 commit intoNixOS:masterfrom rhoriguchi:gnomeExtensions.unite
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
rhoriguchi:gnomeExtensions.unite
Conversation
Member
|
Looks great, thank you. Would you mind also adding yourself to the maintainers of that package using the override? |
Contributor
Author
Sure, I've added myself. |
piegamesde
approved these changes
Oct 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Depends on #140285. Since the current version in
extensions.jsonis lower than the packed one.Use the new override logic from #137131 to add
buildInputs.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)