Skip to content

pythonPackages.obspy: init at 1.2.2#140233

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
matilde-ametrine:master
Oct 3, 2021
Merged

pythonPackages.obspy: init at 1.2.2#140233
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
matilde-ametrine:master

Conversation

@matilde-ametrine
Copy link

@matilde-ametrine matilde-ametrine commented Oct 2, 2021

Motivation for this change

ObsPy is not (yet) part of nixpkgs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 2, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 2, 2021
risicle
risicle reviewed Oct 2, 2021
View reviewed changes
risicle
risicle reviewed Oct 2, 2021
View reviewed changes
@risicle
Copy link
Contributor

risicle commented Oct 2, 2021 •
edited
Loading

Builds for me, executables run, macos 10.15 & nixos x86_64.

SuperSandro2000
SuperSandro2000 requested changes Oct 3, 2021
View reviewed changes
maintainers/maintainer-list.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add NAME and sort it alphabetically.

Copy link
Author

@matilde-ametrine matilde-ametrine Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@SuperSandro2000 SuperSandro2000 merged commit 24347b2 into NixOS:master Oct 3, 2021
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matilde-ametrine @risicle @SuperSandro2000 @Janik-Haag