gotify: 2.0.21 -> 2.1.0 #140139
Merged
gotify: 2.0.21 -> 2.1.0 #140139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangeLog: https://github.com/gotify/server/releases/tag/v2.0.22 ChangeLog: https://github.com/gotify/server/releases/tag/v2.0.23 ChangeLog: https://github.com/gotify/server/releases/tag/v2.1.0 While the update only contains a few small features and a few bugfixes, the change was rather messy for us unfortunately: * It seems as if `npmjs.org`-packages can't be transformed into `pkg___pkg-x.y.z` for Yarn's offline cache. The name `https___registry.npmjs.org_caniuse_lite___caniuse_lite_1.0.30001237.tgz` isn't the problem because when changing the URL "parser" of `yarn2nix` to transform this into `org_caniuse_lite___caniuse_lite_1.0.30001237` this doesn't help either. Instead, I derived the fix from `gitlab`[1] where `yarn.lock` gets patched to make sure that it detects the package in the offline-cache properly. * The frontend is now built with `react-scripts`. This is a problem for us because it tries to write into `node_modules/.cache` even though `node_modules` is a store-path in the context of `yarn2nix`[2]. The change isn't pretty, but solves the issue for us. [1] https://github.com/NixOS/nixpkgs/blob/f007b794c758000a275b00dd0695d2fb155195f0/pkgs/applications/version-management/gitlab/default.nix#L85-L86 [2] facebook/create-react-app#11263
doronbehar
reviewed
Oct 1, 2021
Comment on lines
+34
to
+36
| # react-scripts requires a writable node_modules/.cache, so we have to copy the symlink's contents back | ||
| # into `node_modules/`. | ||
| # See https://github.com/facebook/create-react-app/issues/11263 |
There was a problem hiding this comment.
This comment is good but perhaps should be at the beginning of the buildPhase.
There was a problem hiding this comment.
There are a few more comments related to the blocks separated by whitespace, so I think it's OK to to leave it as-is, right? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ChangeLog: https://github.com/gotify/server/releases/tag/v2.0.22
ChangeLog: https://github.com/gotify/server/releases/tag/v2.0.23
ChangeLog: https://github.com/gotify/server/releases/tag/v2.1.0
While the update only contains a few small features and a few bugfixes,
the change was rather messy for us unfortunately:
It seems as if
npmjs.org-packages can't be transformed intopkg___pkg-x.y.zfor Yarn's offline cache. The namehttps___registry.npmjs.org_caniuse_lite___caniuse_lite_1.0.30001237.tgzisn't the problem because when changing the URL "parser" of
yarn2nixto transform this into
org_caniuse_lite___caniuse_lite_1.0.30001237this doesn't help either.
Instead, I derived the fix from
gitlab[1] whereyarn.lockgetspatched to make sure that it detects the package in the offline-cache
properly.
The frontend is now built with
react-scripts. This is a problem forus because it tries to write into
node_modules/.cacheeven thoughnode_modulesis a store-path in the context ofyarn2nix[2].The change isn't pretty, but solves the issue for us.
[1]
nixpkgs/pkgs/applications/version-management/gitlab/default.nix
Lines 85 to 86 in f007b79
[2] facebook/create-react-app#11263
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)