Skip to content

sigtool: fix build on x86_64-darwin#139271

Closed
r-burns wants to merge 1 commit intoNixOS:masterfrom
r-burns:sigtool
Closed

sigtool: fix build on x86_64-darwin#139271
r-burns wants to merge 1 commit intoNixOS:masterfrom
r-burns:sigtool

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 24, 2021

Motivation for this change

This is currently blocking unstable as it is a prerequisite of the x86_64-darwin -> aarch64-darwin bootstrap tools build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 24, 2021
@r-burns r-burns mentioned this pull request Sep 24, 2021
Merged
12 tasks
@r-burns r-burns added the 1.severity: channel blocker Blocks a channel label Sep 24, 2021
@thefloweringash thefloweringash mentioned this pull request Sep 24, 2021
Merged
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 24, 2021
@r-burns
Copy link
Contributor Author

r-burns commented Sep 24, 2021

Closing in favor of #139272

@r-burns r-burns closed this Sep 24, 2021
@r-burns r-burns deleted the sigtool branch September 24, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@r-burns