Skip to content

transmission: fix error when watch-dir is enabled#139128

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
HexF:patch-1
Oct 18, 2021
Merged

transmission: fix error when watch-dir is enabled#139128
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
HexF:patch-1

Conversation

@HexF
Copy link
Contributor

@HexF HexF commented Sep 23, 2021

Motivation for this change

I discovered a bug causing an error when enabling watch-dir in the settings.

Failed to set up mount namespacing: /run/systemd/unit-root/var/lib/transmission/watchdir: No such file or directory

This patch simply creates the required folder into the activation script, similar to the incomplete-dir setting.

I'm not entirely sure if there is a relevant issue, but if there is please link it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 23, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 23, 2021
@ju1m
Copy link
Contributor

ju1m commented Sep 24, 2021

@HexF, I'm sorry you had to face and fix this bug already fixed in #96655 a PR that I've been trying to get merged since a year.
@SuperSandro2000, if you feel like merging #96655, please do, otherwise merge this simpler one and I'll adapt the other.

@SuperSandro2000 SuperSandro2000 merged commit 5017147 into NixOS:master Oct 18, 2021
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants