MPV: new package#1381
Conversation
|
Hi, I saw on IRC that you wondered why postInstall wasn't run. It's because you have overridden installPhase. The default installPhase runs preInstall, does the default install action, and then runs postInstall. When you set installPhase yourself you must handle pre/post actions yourself. So just merge postInstall into installPhase. Can you do a git rebase --interactive and squash all commits into just one commit (and then force push)? That would give a more easy to read history. |
|
Speaking of easier-to-read history: I use a git alias for log that uses |
|
@vcunat: Thanks for the tip about --first-parent. Hm, it doesn't seem to work with But I still think pull requests should contain as little noise as possible :-) |
It certainly needs a bit of improvement and testing, but it works nicely - so it's a good time to put it to the great public!
|
Thanks! I will do that. In fact I am a bit novice on Git. |
It certainly needs a bit of improvement and testing, but it works nicely - so it's a good time to put it to the great public!
|
Now the git pollution was solved! Also: even if I consider it production-stable, my perfectionist mind can't live with the problems listed at TODO flags. |
|
Oh, silly me, "tig --first-parent" works just fine. I was just in too much of a hurry to notice. (Thanks @vcunat) |
MPV is a movie player, derived from MPlayer/mplayer2, with great improvements.
There are some minor issues, listed in the last four TODO comment lines.