Closed
Conversation
Rebase patches, and fix installing to sysconfdir. The last patch should be upstreamed.
Removes warnings.
'kill-path' no longer exists (as of upstream add384dd4), and as far as I can tell, the 'cryptsetup' option has always been 'libcryptsetup'.
github-actions
bot
added
the
6.topic: systemd
Contributor
Author
|
Some tests, like |
ofborg
bot
added
10.rebuild-darwin: 101-500
Member
|
Perhaps you want to look at #131618 instead. |
Contributor
Author
|
I thought I'd searched for open PRs before starting this, but must have missed that. Thanks for the pointer! |
Member
|
Well, that PR has been closed for two days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
systemd-248 introduces support for TPM-backed LUKS volumes. I want to experiment with this, so tried to bump the systemd version. So far, this fixes some build issues, but many systemd-related tests hang, waiting for the machine to come up (e.g.
systemd-analyze.nix).I'm currently debugging this, but thought I'd post the work on building systemd so far, in case anybody happens to be working on this they can use my build fixes.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)