nixos/activation-script: Fix dependencies for dry activation#137508
nixos/activation-script: Fix dependencies for dry activation#137508ajs124 merged 1 commit intoNixOS:masterfrom
Conversation
ryantm
left a comment
There was a problem hiding this comment.
I think this is a good solution, @dasJ! The only possible issue I see is if some dry activation script has a dependency that doesn't support dry activation, but the dry-activation script depends critically on the dependency running, which seems unlikely to me.
|
I don't think this is a relevant problem because when you get to dry-running anything you have already booted your system, hence all Activation Scripts were already run in non-dry mode. This means all things that I can think of (like setting the hostname, loading kernel modules, …) should have already been run at the point you get get the chance to do a dry activation |
|
@ryantm You should be able to remove your workaround: https://nixpk.gs/pr-tracker.html?pr=137508 |
NixOS/nixpkgs#137508 should remove the need for this.
Motivation for this change
#136605 broke tools like agenix.
The comment in the code should pretty much explain why this fixes it.
For the
simpletest, this results in:Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)