Skip to content

nixos/stage-2-init: Pass arguments#137122

Closed
dasJ wants to merge 1 commit intoNixOS:masterfrom
helsinki-systems:feat/stage-2-pass-args
Closed

nixos/stage-2-init: Pass arguments#137122
dasJ wants to merge 1 commit intoNixOS:masterfrom
helsinki-systems:feat/stage-2-pass-args

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Sep 8, 2021

When running systemd in stage 1, it will pass arguments to the stage 2
systemd, requesting deserialisation of the state. Pass these arguments
to make that work.

Motivation for this change

@arianvp This might play well into #120015.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested review from arianvp and grahamc September 8, 2021 18:28
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 8, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 8, 2021
@dasJ
Copy link
Member Author

dasJ commented Sep 8, 2021

@GrahamcOfBorg test simple

@arianvp
Copy link
Member

arianvp commented Sep 8, 2021

Looks good to me!

@dasJ dasJ closed this Nov 9, 2021
@dasJ dasJ deleted the feat/stage-2-pass-args branch November 9, 2021 11:34
@dasJ dasJ restored the feat/stage-2-pass-args branch March 20, 2022 15:45
@dasJ dasJ reopened this Mar 20, 2022
When running systemd in stage 1, it will pass arguments to the stage 2
systemd, requesting deserialization of the state. Pass these arguments
to make that work.
@dasJ dasJ force-pushed the feat/stage-2-pass-args branch from 5e9d103 to 42c0e20 Compare March 20, 2022 15:48
@dasJ
Copy link
Member Author

dasJ commented Mar 20, 2022

Nvm, this doesn't work

@dasJ dasJ closed this Mar 20, 2022
@dasJ dasJ deleted the feat/stage-2-pass-args branch March 20, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants