Skip to content

virtualbox: remove components/VBoxREM.so when#137114

Merged
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:vboxrem
Sep 8, 2021
Merged

virtualbox: remove components/VBoxREM.so when#137114
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:vboxrem

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Sep 8, 2021

hardened or headless is enabled
arch does it as well
https://github.com/archlinux/svntogit-community/blob/1b2aaf41138f4f00aca84700fe08bb213d909f79/trunk/PKGBUILD#L184

Motivation for this change

Closes #137104

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from svanderburg September 8, 2021 16:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 8, 2021
@otavio
Copy link
Contributor

otavio commented Sep 8, 2021

@SuperSandro2000 this is super annoying, please consider merging this.

@Artturin Artturin merged commit dcce24b into NixOS:master Sep 8, 2021
@Artturin Artturin deleted the vboxrem branch September 8, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

virtualbox: Missing VBoxREM.so

2 participants