Skip to content

diffoscope: 182 -> 183#137112

Merged
Ma27 merged 1 commit intoNixOS:masterfrom
Ma27:bump-diffoscope
Sep 8, 2021
Merged

diffoscope: 182 -> 183#137112
Ma27 merged 1 commit intoNixOS:masterfrom
Ma27:bump-diffoscope

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 8, 2021

Motivation for this change

ChangeLog: https://diffoscope.org/news/diffoscope-183-released/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from danielfullmer and dezgeg September 8, 2021 16:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 8, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 8, 2021

Result of nixpkgs-review pr 137112 at 0e02dd4 run on x86_64-linux 1

2 packages built successfully:
  • diffoscope
  • diffoscopeMinimal
1 suggestion:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/tools/misc/diffoscope/default.nix:22:5:

       |
    22 |     ./ignore_links.patch
       |     ^
    

Result of nixpkgs-review pr 137112 at 0e02dd4 run on aarch64-linux 1

1 package built successfully:
  • diffoscopeMinimal
1 suggestion:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/tools/misc/diffoscope/default.nix:22:5:

       |
    22 |     ./ignore_links.patch
       |     ^
    

@Ma27 Ma27 merged commit 5157953 into NixOS:master Sep 8, 2021
@Ma27 Ma27 deleted the bump-diffoscope branch September 8, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants