Skip to content

htmlq: init at 0.2.0#137064

Merged
siraben merged 1 commit intoNixOS:masterfrom
siraben:htmlq-init
Sep 8, 2021
Merged

htmlq: init at 0.2.0#137064
siraben merged 1 commit intoNixOS:masterfrom
siraben:htmlq-init

Conversation

@siraben
Copy link
Member

@siraben siraben commented Sep 8, 2021 •
edited
Loading

Motivation for this change

Closes #137037.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Sep 8, 2021

Result of nixpkgs-review pr 137064 run on x86_64-darwin 1

1 package built:
  • htmlq

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 8, 2021
@oppiliappan
Copy link
Member

oppiliappan commented Sep 8, 2021

Oh looks like we ended up working on the same thing. Since you have already tested on darwin, I'd say we keep this over #137067.

Would you mind adding doCheck = false since htmlq does not have tests at the moment?

@oppiliappan oppiliappan mentioned this pull request Sep 8, 2021
Closed
12 tasks
@siraben
Copy link
Member Author

siraben commented Sep 8, 2021

Done.

oppiliappan
oppiliappan reviewed Sep 8, 2021
View reviewed changes
pkgs/top-level/all-packages.nix
html-proofer = callPackage ../tools/misc/html-proofer { };

htmlq = callPackage ../development/tools/htmlq {
inherit (pkgs.darwin.apple_sdk.frameworks) Security;
Copy link
Member

@oppiliappan oppiliappan Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inherit (pkgs.darwin.apple_sdk.frameworks) Security;
inherit (darwin.apple_sdk.frameworks) Security;

I think pkgs is not required.

Copy link
Member Author

@siraben siraben Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I just saw this comment. Looks like there are several occurrences of this in all-packages.nix so a file-wide change might be in order.

Copy link
Member

@oppiliappan oppiliappan Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, doesn't look like there is much of a convention.

Looks like there are several occurrences of this in all-packages.nix so a file-wide change might be in order.

Good call.

@oppiliappan
Copy link
Member

oppiliappan commented Sep 8, 2021

Looks good to me!

@siraben siraben merged commit 2d6b693 into NixOS:master Sep 8, 2021
@siraben siraben deleted the htmlq-init branch September 8, 2021 05:42
@siraben
Copy link
Member Author

siraben commented Sep 8, 2021

@NerdyPepper feel free to add yourself to the maintainers list.

@oppiliappan
Copy link
Member

oppiliappan commented Sep 8, 2021

I will take you up on that offer :D

This was referenced Sep 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oppiliappan oppiliappan oppiliappan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

htmlq

2 participants

@siraben @oppiliappan