Skip to content

nodejs-16_x: 16.8.0 -> 16.9.0#137048

Merged
marsam merged 1 commit intoNixOS:masterfrom
marsam:update-nodejs-16_x
Sep 8, 2021
Merged

nodejs-16_x: 16.8.0 -> 16.9.0#137048
marsam merged 1 commit intoNixOS:masterfrom
marsam:update-nodejs-16_x

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 8, 2021

Motivation for this change

https://github.com/nodejs/node/releases/tag/v16.9.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 8, 2021
@happysalada
Copy link
Contributor

Interesting things coming out https://nodejs.org/dist/latest-v16.x/docs/api/corepack.html
the diff looks good.
Thank you!

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 137048 at f60eca1 run on x86_64-linux 1

2 packages skipped due to time constraints:
  • lumo
  • nodejs-16_x (nodejs_latest)
1 package built successfully:
  • nodejs-slim-16_x (nodejs-slim_latest)
2 suggestions:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/web/nodejs/v16.nix:13:17:

       |
    13 |     patches = [ ./disable-darwin-v8-system-instrumentation.patch ];
       |                 ^
    
  • warning: name-and-version

    Did you mean to pass pname instead of name to mkDerivation?

    Near pkgs/development/web/nodejs/nodejs.nix:48:5:

       |
    48 |     name = "${baseName}-${version}";
       |     ^
    

    Near pkgs/development/web/nodejs/nodejs.nix:46:12:

       |
    46 |     inherit version;
       |            ^
    

@marsam marsam merged commit ba29a0d into NixOS:master Sep 8, 2021
@marsam marsam deleted the update-nodejs-16_x branch September 8, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants