home-assistant: pin aioesphomeapi to 7.0.0#137030
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Sep 7, 2021
Merged
Conversation
Relevant comment in the bump of aioesphomeapi: NixOS#135669 (comment)
Contributor
Author
|
ping @mweinelt - asked me to create this PR |
Member
|
I didn't check #135669 properly. 8.0.0 should have go with 2021.9.0 not before. |
Contributor
Author
|
Feel free to close this PR in case |
This was referenced Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version of Home Assistant in nixpkgs is incompatible with
aioesphomeapi-8.0.0, so this PR pins the version.Mandatory to be able to use e.g. lights, otherwise Home Assistant fails with:
Relevant comment in the bump of aioesphomeapi:
#135669 (comment)
Things done
Added it manually via
packageOverrideson theservices.home-assistant.packageoption (so I didn't test the PR in exaclty this form, but an equivalent override).sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)