Skip to content

rust-analyzer: 2021-08-30 -> 2021-09-06#137015

Merged
happysalada merged 3 commits intoNixOS:masterfrom
Mic92:rust-analyzer
Sep 8, 2021
Merged

rust-analyzer: 2021-08-30 -> 2021-09-06#137015
happysalada merged 3 commits intoNixOS:masterfrom
Mic92:rust-analyzer

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 7, 2021 •
edited
Loading

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from oxalica September 7, 2021 18:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 7, 2021
ckiee
ckiee suggested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the same hashes but the update.sh script was not ran so versions aren't bumped everywhere.

@happysalada
Copy link
Contributor

happysalada commented Sep 7, 2021

Result of nixpkgs-review pr 137015 run on x86_64-darwin 1

3 packages built:
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.matklad.rust-analyzer

@Mic92 Mic92 requested a review from jonringer as a code owner September 8, 2021 04:26
@Mic92
Copy link
Member Author

Mic92 commented Sep 8, 2021

I run the update script, does this also mean I need to bump node packages?

@happysalada
Copy link
Contributor

happysalada commented Sep 8, 2021

unfortunately yes.

ckiee
ckiee approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff matches update.sh diff now.

@Mic92
Copy link
Member Author

Mic92 commented Sep 8, 2021

I currently upgrade nodepackages as well.

@Mic92
Copy link
Member Author

Mic92 commented Sep 8, 2021

There you go.

@happysalada
Copy link
Contributor

happysalada commented Sep 8, 2021

Thank you for this!

@happysalada happysalada merged commit e32a756 into NixOS:master Sep 8, 2021
@ofborg ofborg bot requested a review from midchildan September 8, 2021 08:03
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 8, 2021
@Mic92 Mic92 deleted the rust-analyzer branch September 8, 2021 09:01
This was referenced Sep 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oxalica oxalica Awaiting requested review from oxalica

@jonringer jonringer Awaiting requested review from jonringer

@midchildan midchildan Awaiting requested review from midchildan

1 more reviewer

@ckiee ckiee ckiee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mic92 @happysalada @ckiee