Skip to content

python3Packages.mediafile: 0.6.0 -> 0.8.0#136955

Merged
fabaff merged 2 commits intoNixOS:masterfrom
lovesegfault:mediafile-0.8.0
Sep 8, 2021
Merged

python3Packages.mediafile: 0.6.0 -> 0.8.0#136955
fabaff merged 2 commits intoNixOS:masterfrom
lovesegfault:mediafile-0.8.0

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Sep 7, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 7, 2021
@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 7, 2021

Result of nixpkgs-review pr 136955 run on x86_64-linux 1

6 packages built:
  • beets
  • beetsExternalPlugins.alternatives
  • beetsExternalPlugins.copyartifacts
  • beetsExternalPlugins.extrafiles
  • python38Packages.mediafile
  • python39Packages.mediafile

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 7, 2021
@fabaff

This comment has been minimized.

Sign in to view
fabaff
fabaff reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is Python > 3.6. enum34 could be dropped.

risicle
risicle approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 10.15 & nixos x86_64

@lovesegfault lovesegfault requested a review from fabaff September 7, 2021 22:07
@fabaff
Copy link
Member

fabaff commented Sep 8, 2021

Result of nixpkgs-review pr 136955 run on x86_64-linux 1

6 packages built:
  • beets
  • beetsExternalPlugins.alternatives
  • beetsExternalPlugins.copyartifacts
  • beetsExternalPlugins.extrafiles
  • python38Packages.mediafile
  • python39Packages.mediafile

fabaff
fabaff approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit ae31c2b into NixOS:master Sep 8, 2021
@lovesegfault lovesegfault deleted the mediafile-0.8.0 branch September 8, 2021 08:48
This was referenced Sep 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

@risicle risicle risicle approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lovesegfault @fabaff @risicle