Skip to content

lollypop: 1.4.17 -> 1.4.23#136954

Merged
lovesegfault merged 1 commit intoNixOS:masterfrom
lovesegfault:lollypop-1.4.23
Sep 8, 2021
Merged

lollypop: 1.4.17 -> 1.4.23#136954
lovesegfault merged 1 commit intoNixOS:masterfrom
lovesegfault:lollypop-1.4.23

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Sep 7, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 7, 2021

Result of nixpkgs-review pr 136954 run on x86_64-linux 1

1 package built:
  • lollypop

@lovesegfault
Copy link
Member Author

lovesegfault commented Sep 7, 2021

@GrahamcOfBorg eval

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 7, 2021
@lovesegfault lovesegfault merged commit df1552c into NixOS:master Sep 8, 2021
@lovesegfault lovesegfault deleted the lollypop-1.4.23 branch September 8, 2021 17:36
@cpground cpground mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lovesegfault