coqPackages.mathcomp-analysis: 0.3.9 -> 0.3.10#136938
Merged
siraben merged 1 commit intoNixOS:masterfrom Sep 8, 2021
Merged
Conversation
Member
Author
|
Result of 1 package built:
|
AndersonTorres
suggested changes
Sep 7, 2021
Member
There was a problem hiding this comment.
If the old version is not deleted, the commit message's "title" should be coqPackages.mathcomp-analysis: init at 0.3.10, with some explanation such as "including the new version along the older one".
Member
Author
There was a problem hiding this comment.
According to git log, the convention for coqPackages is what I have in the PR. It is understood that for this package set, old versions are not discarded.
a471153 to
714c90e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)