Skip to content

coqPackages.mathcomp-analysis: 0.3.9 -> 0.3.10#136938

Merged
siraben merged 1 commit intoNixOS:masterfrom
siraben:mathcomp-analysis-update
Sep 8, 2021
Merged

coqPackages.mathcomp-analysis: 0.3.9 -> 0.3.10#136938
siraben merged 1 commit intoNixOS:masterfrom
siraben:mathcomp-analysis-update

Conversation

@siraben
Copy link
Member

@siraben siraben commented Sep 6, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@siraben siraben requested review from CohenCyril and vbgl September 6, 2021 21:50
@siraben
Copy link
Member Author

siraben commented Sep 6, 2021

Result of nixpkgs-review pr 136938 run on x86_64-darwin 1

1 package built:
  • coqPackages.mathcomp-analysis

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 6, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the old version is not deleted, the commit message's "title" should be coqPackages.mathcomp-analysis: init at 0.3.10, with some explanation such as "including the new version along the older one".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to git log, the convention for coqPackages is what I have in the PR. It is understood that for this package set, old versions are not discarded.

@siraben siraben force-pushed the mathcomp-analysis-update branch from a471153 to 714c90e Compare September 7, 2021 16:51
@siraben siraben merged commit 228f8be into NixOS:master Sep 8, 2021
@siraben siraben deleted the mathcomp-analysis-update branch September 8, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants