Merged
Conversation
Member
|
Result of 1 package built:
|
bobby285271
approved these changes
Sep 8, 2021
Member
There was a problem hiding this comment.
balena-io/etcher@v1.5.121...v1.5.122 this is small diff, looks good.
Changes:
- Restore image file selection LED-drive pathing [Lorenzo Alberto Maria Ambrosi]
- Update scripts submodule [Lorenzo Alberto Maria Ambrosi]
- Change LEDs colours [Lorenzo Alberto Maria Ambrosi]
- Windows images now show the proper warning again [Lorenzo Alberto Maria Ambrosi]
- Fix Update and install with DNF instructions [Mohamed Salah]
- Add possibile authorization as a query param [JSReds]
- update the windows part [Xtraim]
- Update SUPPORT.md [thambu1710]
- replace make webpack with npm run webpack [Seth Falco]
- Add loader on image select [JSReds]
- add pnp-webpack-plugin [Zane Hitchcox]
- Remove redundant codespell dependency/tests [Lorenzo Alberto Maria Ambrosi]
Builds, tested basic functionality, works for me.
Member
|
@ofborg eval |
This was referenced Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/balena-io/etcher/releases.
meta.description for etcher is: "Flash OS images to SD cards and USB drives, safely and easily"
meta.homepage for etcher is: "https://etcher.io/"
meta.changelog for etcher is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passedWarning: no invocation of /nix/store/ydjpxlqwczqllp0639jpkpl7dkl8mkli-etcher-1.5.122/bin/etcher had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.5.122 with grep in /nix/store/ydjpxlqwczqllp0639jpkpl7dkl8mkli-etcher-1.5.122
found 1.5.122 in filename of file in /nix/store/ydjpxlqwczqllp0639jpkpl7dkl8mkli-etcher-1.5.122
directory tree listing: https://gist.github.com/4912e41cc786ffefac950964adf4f7b0
du listing: https://gist.github.com/599170598ff46a3d4af60a47d3640bb2
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-reviewrun on x86_64-linux 11 package built:
Maintainer pings
cc @Shou for testing.