stdenv: fix __bootPackages when overriding#136804
Closed
r-burns wants to merge 1 commit intoNixOS:masterfrom
Closed
stdenv: fix __bootPackages when overriding#136804r-burns wants to merge 1 commit intoNixOS:masterfrom
r-burns wants to merge 1 commit intoNixOS:masterfrom
Conversation
Now that we override stdenv instead of using // since f110a18, the __bootPackages and __hatPackages attrs that were added using // are discarded. This restores them so that they are still exposed in e.g. pkgsStatic.
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Contributor
Author
|
Was no longer able to reproduce this issue on a50861d |
Member
|
oh that's convenient! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we override stdenv instead of using // since f110a18, the __bootPackages and __hatPackages attrs that were added using // are discarded. This restores them so that they are still exposed in e.g. pkgsStatic.
see #134463 (comment)
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)