Skip to content

vimPlugins.nvim-solarized-lua: init at 2021-07-09#136288

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
yaymukund:nvim-solarized-lua
Sep 7, 2021
Merged

vimPlugins.nvim-solarized-lua: init at 2021-07-09#136288
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
yaymukund:nvim-solarized-lua

Conversation

@yaymukund
Copy link

@yaymukund yaymukund commented Aug 31, 2021

Motivation for this change

I'd like to add this neovim plugin:

https://github.com/ishan9299/nvim-solarized-lua

I've tested it locally as follows, and it seems to work:

let
  local-nixpkgs = import (builtins.fetchGit {
    name = "local-nixpkgs";
    url = "/path/to/local/nixpkgs";
  }) {};
in
  # and then in my neovim packages list:
  # ...
  packages.my-plugins = {
    start = [
      # ...
      local-nixpkgs.vimPlugins.nvim-solarized-lua
    ]
  }
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yaymukund yaymukund requested a review from jonringer as a code owner August 31, 2021 11:42
@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Aug 31, 2021
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 31, 2021
@ofborg ofborg bot requested a review from jorsn August 31, 2021 11:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 31, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 31, 2021

Result of nixpkgs-review pr 136288 at aaf4b86e run on aarch64-linux 1

2 packages built successfully:
  • spacevim
  • vimPlugins.vim-clap
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Result of nixpkgs-review pr 136288 at aaf4b86e run on x86_64-linux 1

43 packages built successfully:
  • spacevim
  • tests.vim.test_vim_with_vim_nix
  • tests.vim.test_vim_with_vim_nix_using_plug
  • vimPlugins.LeaderF
  • vimPlugins.auto-session
  • vimPlugins.chadtree
  • vimPlugins.cmp-nvim-lua
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.feline-nvim
  • vimPlugins.fugitive-gitlab-vim
  • vimPlugins.fzf-vim
  • vimPlugins.glow-nvim
  • vimPlugins.gruvbox-nvim
  • vimPlugins.luasnip
  • vimPlugins.lush-nvim
  • vimPlugins.neoformat
  • vimPlugins.neogit
  • vimPlugins.neovim-ayu
  • vimPlugins.null-ls-nvim
  • vimPlugins.nvim-autopairs
  • vimPlugins.nvim-cmp
  • vimPlugins.nvim-compe
  • vimPlugins.nvim-gps
  • vimPlugins.nvim-solarized-lua
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-web-devicons
  • vimPlugins.nvim_context_vt
  • vimPlugins.onedark-nvim
  • vimPlugins.packer-nvim
  • vimPlugins.rust-vim
  • vimPlugins.sql-nvim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.tokyonight-nvim
  • vimPlugins.vim-clap
  • vimPlugins.vim-dadbod-completion
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-grepper
  • vimPlugins.vim-plug
  • vimPlugins.vim-visual-multi
  • vimPlugins.vim-xkbswitch
  • vimPlugins.vimtex
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

@figsoda figsoda added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 7, 2021
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 7, 2021
@SuperSandro2000 SuperSandro2000 merged commit 371e2ff into NixOS:master Sep 7, 2021
@yaymukund yaymukund deleted the nvim-solarized-lua branch September 7, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants