Skip to content

ipv6calc: 2.2.0 -> 3.2.0#136168

Merged
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:bump-ipv6calc
Sep 8, 2021
Merged

ipv6calc: 2.2.0 -> 3.2.0#136168
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:bump-ipv6calc

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Aug 30, 2021

Motivation for this change

Update to latest upstream release 3.2.0

Change log:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff fabaff added the 9.needs: maintainer Package or module needs active maintainers label Aug 30, 2021
@fabaff
Copy link
Member Author

fabaff commented Aug 30, 2021

Result of nixpkgs-review pr 136168 run on x86_64-linux 1

2 packages built:
  • ip2location-c
  • ipv6calc

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 30, 2021
@mweinelt
Copy link
Member

mweinelt commented Aug 30, 2021

$ ./bin/ip2location 
Datafile is absent

$ fd
bin
bin/ip2location
include
include/IP2Location.h
lib
lib/libIP2Location.la
lib/libIP2Location.so
lib/libIP2Location.so.3
lib/libIP2Location.so.3.0.0
share
share/man
share/man/man1
share/man/man1/ip2location.1.gz

That looks somewhat incomplete.

@fabaff
Copy link
Member Author

fabaff commented Aug 30, 2021

For some databases a license is required. They provide free databases called "IP2Location™ LITE". Those are licensed under CC-BY-SA, require a specific acknowledgment and have lower data accuracy than the licensed DBs. E.g.,

]$ ./bin/ip2location -d /home/fab/geo-location/IP2LOCATION-LITE-DB1.BIN -p 80.219.53.100 -e country_name
"country_name"
"Switzerland"

I don't think that we should ship those DBs and leave it up to the user to decide which one to use. From a ipv6calc point of view this is somehow an inconvenience as lookups are only backed by built-in data.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 30, 2021

Result of nixpkgs-review pr 136168 at ed7e5ab run on aarch64-linux 1

2 packages built successfully:
  • ip2location-c
  • ipv6calc
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/ip2location-c/default.nix:38:5:

       |
    38 |     maintainers = with maintainers; [ ];
       |     ^
    

Result of nixpkgs-review pr 136168 at ed7e5ab run on x86_64-linux 1

2 packages built successfully:
  • ip2location-c
  • ipv6calc
3 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/tools/networking/ipv6calc/default.nix:68:5:

       |
    68 |     maintainers = with maintainers; [ ];
       |     ^
    
  • warning: build-tools-in-build-inputs

    getopt is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/tools/networking/ipv6calc/default.nix:23:3:

       |
    23 |   buildInputs = [
       |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/ip2location-c/default.nix:38:5:

       |
    38 |     maintainers = with maintainers; [ ];
       |     ^
    

@fabaff fabaff merged commit 6eadd15 into NixOS:master Sep 8, 2021
@fabaff fabaff deleted the bump-ipv6calc branch September 8, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants