Skip to content

python3Packages.async-upnp-client: 0.19.2 -> 0.20.0#135038

Merged
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:bump-async-upnp-client
Aug 22, 2021
Merged

python3Packages.async-upnp-client: 0.19.2 -> 0.20.0#135038
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:bump-async-upnp-client

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Aug 21, 2021

Motivation for this change

Update to latest upstream release 0.20.0

Change log: https://github.com/StevenLooman/async_upnp_client/blob/development/CHANGES.rst

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners August 21, 2021 07:47
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 21, 2021
@ofborg ofborg bot requested a review from mweinelt August 21, 2021 07:58
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 21, 2021
@risicle
Copy link
Copy Markdown
Contributor

risicle commented Aug 21, 2021

nixpkgs-review happy, macos 10.15

@fabaff fabaff merged commit 870959c into NixOS:master Aug 22, 2021
@fabaff fabaff deleted the bump-async-upnp-client branch August 22, 2021 07:53
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Aug 24, 2021

Breaking change: The target_ip argument of search.SSDPListener has been dropped and replaced with target which takes a AddressTupleVXType

ERROR:homeassistant:Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/build/source/homeassistant/components/ssdp/__init__.py", line 249, in async_start
    SSDPListener(
  File "/build/source/tests/components/ssdp/test_init.py", line 599, in _generate_fake_ssdp_listener
    listener = SSDPListener(*args, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'target_ip'

FYI: This update broke home-assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants