Closed
Conversation
- Use the generic builder and override build and install phases instead
of using buildCommand and missing phases and hooks, like fixup.
- Fix build on Darwin by using the proper build script (ccc.osx).
- Add cctools to build inputs because ccc.osx uses the libtool
command.
- The install_name of the library is not set so fix it with
fixDarwinDylibNames.
- Install headers into the expected location $out/include/lpsolve
instead of $out/include. This follows what other distro do.
Member
Author
|
God I hate GitHub so much |
Member
|
This should target master while testing so it can be compared to https://hydra.nixos.org/jobset/nixpkgs/trunk. |
Member
Author
|
I'm just going to make a new PR, GitHub is just far too cursed |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hello binutils, my old friend
I've come to bump you again
Because a version softly creeping
Left its bugs while I was sleeping
And the patches that were planted in my brain
Still remains
Within the source of binutils
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)