Skip to content

binutils: 2.35.1 -> 2.37#134916

Closed
lovesegfault wants to merge 157 commits intostagingfrom
binutils-2.37
Closed

binutils: 2.35.1 -> 2.37#134916
lovesegfault wants to merge 157 commits intostagingfrom
binutils-2.37

Conversation

@lovesegfault
Copy link
Member

Motivation for this change

Hello binutils, my old friend
I've come to bump you again
Because a version softly creeping
Left its bugs while I was sleeping
And the patches that were planted in my brain
Still remains
Within the source of binutils

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

emilytrau and others added 30 commits August 13, 2021 20:59
- Use the generic builder and override build and install phases instead
  of using buildCommand and missing phases and hooks, like fixup.

- Fix build on Darwin by using the proper build script (ccc.osx).

  - Add cctools to build inputs because ccc.osx uses the libtool
    command.

  - The install_name of the library is not set so fix it with
    fixDarwinDylibNames.

- Install headers into the expected location $out/include/lpsolve
  instead of $out/include. This follows what other distro do.
@github-actions github-actions bot added the 8.has: module (update) This PR changes an existing module in `nixos/` label Aug 20, 2021
@lovesegfault
Copy link
Member Author

God I hate GitHub so much

@TredwellGit
Copy link
Member

This should target master while testing so it can be compared to https://hydra.nixos.org/jobset/nixpkgs/trunk.

@lovesegfault
Copy link
Member Author

I'm just going to make a new PR, GitHub is just far too cursed

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 20, 2021
@lovesegfault lovesegfault mentioned this pull request Aug 20, 2021
12 tasks
@lovesegfault lovesegfault removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: vim Advanced text editor labels Aug 20, 2021
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Aug 20, 2021
@ofborg ofborg bot requested a review from Ericson2314 August 20, 2021 02:53
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.