Skip to content

tasks/lvm: add all tools from thin-provisioning-tools#132786

Merged
Lassulus merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/initrd-dm-cache
Sep 8, 2021
Merged

tasks/lvm: add all tools from thin-provisioning-tools#132786
Lassulus merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/initrd-dm-cache

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Aug 5, 2021

Motivation for this change

This should barely increase the size of the initrd, because these are all symlinks.
With this, systems with dm-cache/lvmcache can also be booted, although the kernel modules for the relevant dm targets still need to be added to the initrd with boot.initrd.kernelModules.

Closes #46541

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 5, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 5, 2021
@ajs124 ajs124 force-pushed the feat/initrd-dm-cache branch from ae1fa6c to ff10a77 Compare August 5, 2021 14:14
@ajs124 ajs124 marked this pull request as ready for review August 5, 2021 14:16
@ajs124 ajs124 requested a review from flokli August 5, 2021 14:16
@ajs124
Copy link
Member Author

ajs124 commented Aug 5, 2021

cc @YorikSar @SnVIZQ

@ajs124
Copy link
Member Author

ajs124 commented Aug 19, 2021

I'd love to get some feedback or more testing for this, but if no-one replies, I'll probably merge it in a week or two.

@ajs124 ajs124 force-pushed the feat/initrd-dm-cache branch from ff10a77 to a8f94ab Compare August 20, 2021 10:35
This should barely increase the size of the initrd, because these are all symlinks.
With this, systems with dm-cache/lvmcache can also be booted, although the kernel modules for the relevant dm targets still need to be added to the initrd with boot.initrd.kernelModules.
@ajs124 ajs124 force-pushed the feat/initrd-dm-cache branch from a8f94ab to f358f73 Compare August 20, 2021 11:24
@Lassulus Lassulus merged commit 7cd6b6d into NixOS:master Sep 8, 2021
@ajs124 ajs124 deleted the feat/initrd-dm-cache branch September 8, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants