nixos/filesystems: succeed mount-pstore.service without backend#131587
Conversation
9 tasks
Member
|
Why do we even need this mount unit in the first place? systemd should just mount this automatically: systemd/systemd@c06bf41 |
Author
|
In NixOS systemd isn't responsible for mounting any of the special filesystems. I am not sure why that is. Probably just for legacy reasons. |
Author
|
The blocking test now suceeds. |
Contributor
|
I confirm I've been getting the following error in the last couple of days and this PR removes the ERROR. |
Member
|
Let's merge this, to unblock the channel and figure out why systemd doesn't mount those things automatically later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unbreaks the
simpletest frominstaller.nix, which is currently blocking thenixos-unstablechannel.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)