Skip to content

nixos/filesystems: succeed mount-pstore.service without backend#131587

Merged
ajs124 merged 1 commit intomasterfrom
unknown repository
Jul 27, 2021
Merged

nixos/filesystems: succeed mount-pstore.service without backend#131587
ajs124 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 26, 2021

Motivation for this change

Unbreaks the simple test from installer.nix, which is currently blocking the nixos-unstable channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 26, 2021
@ajs124
Copy link
Member

ajs124 commented Jul 26, 2021

Why do we even need this mount unit in the first place? systemd should just mount this automatically: systemd/systemd@c06bf41

@ajs124 ajs124 requested a review from andir July 26, 2021 16:18
@ghost
Copy link
Author

ghost commented Jul 26, 2021

In NixOS systemd isn't responsible for mounting any of the special filesystems. I am not sure why that is. Probably just for legacy reasons.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 26, 2021
@ghost
Copy link
Author

ghost commented Jul 26, 2021

The blocking test now suceeds.

@ghost ghost marked this pull request as ready for review July 26, 2021 17:29
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Jul 27, 2021
@happysalada
Copy link
Contributor

happysalada commented Jul 27, 2021

I confirm I've been getting the following error in the last couple of days

89ji0y3y98aq4kppbfi01-mount-pstore.sh[3284118]: Persistent Storage backend was not registered in time.
: mount-pstore.service: Main process exited, code=exited, status=1/FAILURE
: mount-pstore.service: Failed with result 'exit-code'.
: Failed to start mount-pstore.service.

and this PR removes the ERROR.

@ajs124
Copy link
Member

ajs124 commented Jul 27, 2021

Let's merge this, to unblock the channel and figure out why systemd doesn't mount those things automatically later.

@ajs124 ajs124 merged commit ce08072 into NixOS:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants