Skip to content

ocamlPackages.letsencrypt: 0.2.5 -> 0.3.0#131333

Merged
lukegb merged 1 commit intoNixOS:masterfrom
sternenseemann:letsencrypt-0.3.0
Jul 25, 2021
Merged

ocamlPackages.letsencrypt: 0.2.5 -> 0.3.0#131333
lukegb merged 1 commit intoNixOS:masterfrom
sternenseemann:letsencrypt-0.3.0

Conversation

@sternenseemann
Copy link
Member

ocamlPackages.letsencrypt-dns: init at 0.3.0
ocamlPackages.letsencrypt-app: init at 0.2.5

https://github.com/mmaker/ocaml-letsencrypt/releases/tag/v0.3.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Jul 24, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 24, 2021
ocamlPackages.letsencrypt-dns: init at 0.3.0
ocamlPackages.letsencrypt-app: init at 0.2.5

https://github.com/mmaker/ocaml-letsencrypt/releases/tag/v0.3.0
@lukegb
Copy link
Contributor

lukegb commented Jul 25, 2021

🐫

@lukegb lukegb merged commit c53dafb into NixOS:master Jul 25, 2021
@sternenseemann sternenseemann deleted the letsencrypt-0.3.0 branch July 25, 2021 09:44
@vbgl
Copy link
Contributor

vbgl commented Jul 25, 2021

This broke ocamlPackages.paf.

@sternenseemann
Copy link
Member Author

You're right, we'll have to revert for now. For some reason even the nixpkgs-review local eval was convinced letsencrypt was a leaf package and didn't build any reverse deps, sorry about that.

I believe such cases should be avoided by #126934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants