Skip to content

mopidy-spotify: 2.2.0 -> 2.3.1#13062

Merged
fpletz merged 1 commit intoNixOS:masterfrom
datakurre:datakurre-mopidy-spotify
Feb 17, 2016
Merged

mopidy-spotify: 2.2.0 -> 2.3.1#13062
fpletz merged 1 commit intoNixOS:masterfrom
datakurre:datakurre-mopidy-spotify

Conversation

@datakurre
Copy link
Copy Markdown
Contributor

v2.3.1 (2016-02-14)

Bug fix release.

  • Require Mopidy < 2 as Mopidy 2.0 breaks the audio API with the upgrade to
    GStreamer 1.
  • Use the new Spotify Web API for search. Searching through libspotify has been
    discontinued and is not working anymore. (Fixes: Add IntelliJ IDEA CE version 11. #89)
  • Note that search through the Spotify Web API doesn't return artists or date
    for albums. This also means that library.get_distinct() when given type
    albumartist or date and a query only returns an empty set.
  • Emit a warning if config value spotify/search_album_count,
    spotify/search_artist_count, or spotify/search_track_count is greater
    than 50, and use 50 instead. 50 is the maximum value that the Spotify Web API
    allows. The maximum in the config schema is not changed to not break existing
    configs.

v2.3.0 (2016-02-06)

Feature release.

  • Ignore all audio data deliveries from libspotify when when a seek is in
    progress. This ensures that we don't deliver audio data from before the seek
    with timestamps from after the seek.
  • Ignore duplicate end of track callbacks.
  • Don't increase the audio buffer timestamp if the buffer is rejected by
    Mopidy. This caused audio buffers delivered after one or more rejected audio
    buffers to have too high timestamps.
  • When changing tracks, block until Mopidy completes the appsrc URI change.
    Not blocking here might break gapless playback.
  • Lookup of a playlist you're not subscribed to will now properly load all of
    the playlist's tracks. (Fixes: dbus: Merge dbus-library, dbus-tools and dbus-daemon into a single package #81, PR: chromium: Update channels for stable version 21. #82)
  • Workaround teardown race outputing lots of short stack traces on Mopidy
    shutdown. (See Haskell snap #73 for details)

@mention-bot
Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified @fpletz, @rickynils and @pSub to be potential reviewers

@fpletz fpletz added the 8.has: package (update) This PR updates a package to a newer version label Feb 17, 2016
@fpletz
Copy link
Copy Markdown
Member

fpletz commented Feb 17, 2016

Thanks! 🍻 I didn't have the time yet to investigate why the spotify search was broken. Waiting for Travis, then I'll merge.

@datakurre
Copy link
Copy Markdown
Contributor Author

@fpletz It was a productivity blocker :)

@fpletz
Copy link
Copy Markdown
Member

fpletz commented Feb 17, 2016

Well, although travis still builds we had to test this locally on our mopidy. Works like a charm! 👍

fpletz added a commit that referenced this pull request Feb 17, 2016
@fpletz fpletz merged commit 1b40dec into NixOS:master Feb 17, 2016
@datakurre datakurre deleted the datakurre-mopidy-spotify branch February 18, 2016 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants