Conversation
github-actions
bot
added
the
6.topic: python
|
@ofborg eval (Sorry, ofborg's certs recently had an issue, meaning that it was unable to |
ofborg
bot
added
8.has: clean-up
| pgadmin4 = callPackage ../tools/admin/pgadmin { }; | ||
|
|
||
| pgadmin3 = callPackage ../applications/misc/pgadmin { |
There was a problem hiding this comment.
Please move the files to one place and append version numbers to the directories.
| pytz | ||
| simplejson | ||
| six | ||
| (lib.hiPrio speaklater3) |
There was a problem hiding this comment.
Why does this need to be hiPrio?
|
|
||
| postPatch = '' | ||
| # sed -r 's|LC_ALL=en_US.UTF-8.* Makefile.sphinx .*$|true|g' -i Makefile | ||
| patchShebangs . |
There was a problem hiding this comment.
Please specify the files/directories that need patching?
| format = "other"; | ||
|
|
There was a problem hiding this comment.
| format = "other"; |
|
|
||
| python3Packages.buildPythonApplication rec { | ||
| pname = "pgadmin"; | ||
| version = "5.4"; |
There was a problem hiding this comment.
| version = "5.4"; | |
| version = "5.4"; | |
| format = "other"; |
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "Flask-Paranoid"; |
There was a problem hiding this comment.
| pname = "Flask-Paranoid"; | |
| pname = "flask-paranoid"; |
| homepage = "https://github.com/zzzsochi/Flask-Gravatar"; | ||
| description = "Small and simple integration of gravatar into flask"; | ||
| license = licenses.bsd3; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
| platforms = platforms.all; |
| preBuild = '' | ||
| sed "s|tests_require=tests_require,||g" -i setup.py | ||
| sed "s|extras_require=extras_require,||g" -i setup.py | ||
| sed "s|setup_requires=setup_requires,||g" -i setup.py | ||
| ''; |
There was a problem hiding this comment.
Use postPatch and substituteInPlace.
| sha256 = "YGZfMcLGEokdto/4Aek+06CIHGyOw0arxk0qmSP1YuE="; | ||
| }; | ||
|
|
||
| # depends on pytest-pep8 which is abandoned, not going to bother |
There was a problem hiding this comment.
Are there integration or just liting tests? pythonImportsCheck?
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "Flask-Gravatar"; |
There was a problem hiding this comment.
| pname = "Flask-Gravatar"; | |
| pname = "flask-gravatar"; |
|
@mkg20001 are you still working on this and/or need some help with testing? |
|
I'm no longer actively working on this PR, but feel free to pickup where I've left off If you have commit access to nixpkgs you should be able to push directly to this fork's branch |
|
@mkg20001 |
|
Superseded by #154764 |
5 participants
Motivation for this change
An attempt to package pgadmin4
NOTE: Currently does not work, but it's pretty close
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)