WIP: virt-manager: enable aarch64-darwin#128767
Conversation
github-actions
bot
added
the
6.topic: python
|
This builds, but virt-manager is segfaulting, so not usable at this time. |
|
It now works on x86_64-darwin (only can test it via rosetta) |
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
Please convert all platforms.linux ++ platforms.darwin to platforms.unix
|
|
||
| libvirt = callPackage ../development/libraries/libvirt { }; | ||
| libvirt = callPackage ../development/libraries/libvirt { | ||
| inherit (darwin.apple_sdk.frameworks) Carbon AppKit; |
There was a problem hiding this comment.
| inherit (darwin.apple_sdk.frameworks) Carbon AppKit; | |
| inherit (darwin.apple_sdk.frameworks) AppKit Carbon; |
| mesonFlags = [ | ||
| ] ++ lib.optional stdenv.isDarwin "-Dpulseaudio=disabled"; |
There was a problem hiding this comment.
| mesonFlags = [ | |
| ] ++ lib.optional stdenv.isDarwin "-Dpulseaudio=disabled"; | |
| mesonFlags = lib.optional stdenv.isDarwin "-Dpulseaudio=disabled"; |
| cairo | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Do the tests not work on aarch64-darwin?
There was a problem hiding this comment.
No, they failed. Would like to der able them. But did not figured out how yet
| mesonFlags = [ | ||
| ] ++ lib.optional stdenv.isDarwin [ | ||
| "-D_b_symbolic_functions=false" | ||
| ]; |
There was a problem hiding this comment.
| mesonFlags = [ | |
| ] ++ lib.optional stdenv.isDarwin [ | |
| "-D_b_symbolic_functions=false" | |
| ]; | |
| mesonFlags = lib.optionals stdenv.isDarwin [ | |
| "-D_b_symbolic_functions=false" | |
| ]; |
| glusterfs | ||
| ] ++ optionals stdenv.isDarwin [ | ||
| libiconv gmp | ||
| libiconv gmp gnumake Carbon AppKit |
There was a problem hiding this comment.
Isn't gnumake part of the stdenv?
There was a problem hiding this comment.
Could be. libvirt expects gnumake as gmake. Added this as debugging.
| , meson, ninja, audit, cmake, bash-completion, pkg-config | ||
| , Carbon, AppKit | ||
| , gnumake | ||
| , enableXen ? false, xen ? null |
There was a problem hiding this comment.
| , enableXen ? false, xen ? null | |
| , enableXen ? false, xen |
|
|
||
| checkInputs = with python3Packages; [ cpio cdrtools pytestCheckHook ]; | ||
| doCheck = false; | ||
| checkInputs = with python3Packages; [ cpio pytestCheckHook ] ++ lib.optional stdenv.isLinux cdrtool; |
There was a problem hiding this comment.
| checkInputs = with python3Packages; [ cpio pytestCheckHook ] ++ lib.optional stdenv.isLinux cdrtool; | |
| checkInputs = with python3Packages; [ cpio pytestCheckHook ] | |
| ++ lib.optional stdenv.isLinux cdrtools; |
| ''; | ||
|
|
||
| checkInputs = with python3Packages; [ cpio cdrtools pytestCheckHook ]; | ||
| doCheck = false; |
There was a problem hiding this comment.
Do the tests not work on aarch64-darwin?
| pygobject3 ipaddress libvirt libxml2 requests cdrtools | ||
| ]; | ||
| pygobject3 ipaddress libvirt libxml2 requests | ||
| ] ++ lib.optional stdenv.isLinux cdrtool; |
There was a problem hiding this comment.
| ] ++ lib.optional stdenv.isLinux cdrtool; | |
| ] ++ lib.optional stdenv.isLinux cdrtools; |
| propagatedBuildInputs = with python3Packages; [ | ||
| pygobject3 ipaddress libvirt libxml2 requests cdrtools | ||
| ]; | ||
| pygobject3 ipaddress libvirt libxml2 requests |
There was a problem hiding this comment.
| pygobject3 ipaddress libvirt libxml2 requests | |
| pygobject3 ipaddress libvirt libxml2 requests |
| "-Dpolkit=${if withPolkit then "enabled" else "disabled"}" | ||
| ] ++ lib.optionals stdenv.isDarwin [ | ||
| "-Dwebdav=disabled" | ||
| "-Dusbredir=disabled" |
There was a problem hiding this comment.
| "-Dusbredir=disabled" | |
| "-Dusbredir=disabled" |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing because #152350 will supercede this. |
stale
bot
removed
the
2.status: stale
3 participants
Motivation for this change
virt-manager on aarch64-darwin.
Things done
enabled many packages for
platforms.darwin.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)