Skip to content

[WIP] vscode-extensions: auto-update many#127741

Closed
kamadorueda wants to merge 7 commits intoNixOS:masterfrom
kamadorueda:master
Closed

[WIP] vscode-extensions: auto-update many#127741
kamadorueda wants to merge 7 commits intoNixOS:masterfrom
kamadorueda:master

Conversation

@kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jun 22, 2021

Motivation for this change

Keeping extensions updated is normally a thing you want to do,
but I'm too lazy as to do it manually on a daily basis so I'm:

  • Extending a little bit the current script with a feature flag that updates the code in-place and even do the commit
  • Updating my extension set to their latest version
  • If you agree, I could work on applying this strategy to more packages, similar to what niv and nixpkgs-updated do. With small refactors auto-updating is easy
  • This PR seems big, but read it 1 commit at a time and it'll be easier
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kamadorueda kamadorueda requested a review from jonringer as a code owner June 22, 2021 02:58
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 22, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 127741 at 814b40d run on x86_64-linux 1

7 packages built successfully:
  • vscode-extensions._4ops.terraform
  • vscode-extensions.coenraads.bracket-pair-colorizer-2
  • vscode-extensions.haskell.haskell
  • vscode-extensions.ms-python.python
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.ms-toolsai.jupyter
  • vscode-extensions.tamasfe.even-better-toml

@SuperSandro2000
Copy link
Member

@jonringer can you review this?

@jonringer
Copy link
Contributor

do you mind adding a doc/languages-frameworks/vscode.section.md with some instructions on how to update the extensions?

@kamadorueda
Copy link
Member Author

do you mind adding a doc/languages-frameworks/vscode.section.md with some instructions on how to update the extensions?

Actually I really like the idea, I'm gonna work on it

@kamadorueda kamadorueda changed the title vscode-extensions: auto-update many [WIP] vscode-extensions: auto-update many Jun 24, 2021
@cideM
Copy link
Contributor

cideM commented Jul 1, 2021

@kamadorueda you can maybe take some inspiration from #113280 where I also wrote documentation on VSCode extensions.

For what it's worth, I'll maybe see if I can just add another shell script or so which let's users update extensions from STDIN rather than getting them from VSCode, which is a bit brittle. I think the current script doesn't even consider all possible binary names.

So in other words, my typical use case is "foo.bar" | update_ext rather than always updating all of them at the same time.

@kamadorueda kamadorueda closed this Aug 1, 2021
@jul1u5
Copy link
Contributor

jul1u5 commented Aug 26, 2021

Why was this closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants