lib/options: Warn about options without type

lib/options.nix

@@ -185,7 +185,13 @@ rec {
             then true
             else opt.visible or true;
           readOnly = opt.readOnly or false;
-          type = opt.type.description or null;
+          type =
+            if opt.type.name == "unspecified"
+            then lib.warn
+              ("Option `${showOption loc}' defined in ${showFiles opt.declarations} has no type.\n"
+              +"       Please specify a valid types from <nixpkgs/lib/types.nix> or use types.raw if there is no appropriate type.")
+              null
+            else opt.type.description or null;
         }
         // optionalAttrs (opt ? example) { example = scrubOptionValue opt.example; }
         // optionalAttrs (opt ? default) { default = scrubOptionValue opt.default; }

nixos/doc/manual/development/option-declarations.section.md

@@ -27,9 +27,8 @@ The function `mkOption` accepts the following arguments.
 
 `type`
 
-:   The type of the option (see [](#sec-option-types)). It may be
-    omitted, but that's not advisable since it may lead to errors that
-    are hard to diagnose.
+:   The type of the option (see [](#sec-option-types)). This
+    argument is mandatory.
 
 `default`
 

nixos/doc/manual/from_md/development/option-declarations.section.xml

@@ -38,9 +38,8 @@ options = {
       <listitem>
         <para>
           The type of the option (see
-          <xref linkend="sec-option-types" />). It may be omitted, but
-          that’s not advisable since it may lead to errors that are hard
-          to diagnose.
+          <xref linkend="sec-option-types" />). This argument is
+          mandatory.
         </para>
       </listitem>
     </varlistentry>

nixos/modules/services/networking/nsd.nix

@@ -247,6 +247,7 @@ let
 
       children = mkOption {
         default = {};
+        type = types.attrsOf types.unspecified;
         description = ''
           Children zones inherit all options of their parents. Attributes
           defined in a child will overwrite the ones of its parent. Only

nixos/modules/services/networking/unbound.nix

@@ -62,6 +62,7 @@ in {
       };
 
       stateDir = mkOption {
+        type = types.path;
         default = "/var/lib/unbound";
         description = "Directory holding all state for unbound to run.";
       };

nixos/modules/services/networking/vsftpd.nix

@@ -153,6 +153,7 @@ in
 
       userlist = mkOption {
         default = [];
+        type = types.listOf types.str;
         description = "See <option>userlistFile</option>.";
       };
 

nixos/modules/services/x11/display-managers/default.nix

@@ -217,6 +217,24 @@ in
 
       session = mkOption {
         default = [];
+        type = with types; listOf (submodule ({ ... }: {
+          options = {
+            manage = mkOption {
+              description = "Whether this is a desktop or a window manager";
+              type = enum [ "desktop" "window" ];
+            };
+
+            name = mkOption {
+              description = "Name of this session";
+              type = str;
+            };
+
+            start = mkOption {
+              description = "Commands to run to start this session";
+              type = lines;
+            };
+          };
+        }));
         example = literalExpression
           ''
             [ { manage = "desktop";

nixos/modules/system/boot/kernel.nix

@@ -36,7 +36,7 @@ in
 
     boot.kernelPackages = mkOption {
       default = pkgs.linuxPackages;
-      type = types.unspecified // { merge = mergeEqualOption; };
+      type = types.anything // { merge = mergeEqualOption; };
       apply = kernelPackages: kernelPackages.extend (self: super: {
         kernel = super.kernel.override (originalArgs: {
           inherit randstructSeed;

nixos/modules/system/boot/stage-1.nix

@@ -575,7 +575,7 @@ in
         else "gzip"
       );
       defaultText = literalDocBook "<literal>zstd</literal> if the kernel supports it (5.9+), <literal>gzip</literal> if not";
-      type = types.unspecified; # We don't have a function type...
+      type = types.anything; # We don't have a function type...
       description = ''
         The compressor to use on the initrd image. May be any of: