Skip to content

[20.09] python3Packages.starlette: fix build#125213

Merged
risicle merged 1 commit intoNixOS:release-20.09from
risicle:ris-starlette-alt-fix-r20.09
Jun 25, 2021
Merged

[20.09] python3Packages.starlette: fix build#125213
risicle merged 1 commit intoNixOS:release-20.09from
risicle:ris-starlette-alt-fix-r20.09

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Jun 1, 2021 •
edited
Loading

Motivation for this change

Our switch to python 3.8.8+ broke this, because it exposes some breakage and causes a test to fail. Documented Kludex/starlette#1131 and fixed Kludex/starlette#1132. Cherry pick that patch to get 20.09's starlette building again.

Apologies to 20.09 users for leaving this broken so long.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@risicle
python3Packages.starlette: fix build
3777863 
newer python 3.8+ releases expose this breakage
Kludex/starlette#1131, fixed upstream in
Kludex/starlette#1132
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 1, 2021
@ofborg ofborg bot requested a review from wd15 June 1, 2021 12:26
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 1, 2021
@risicle risicle marked this pull request as ready for review June 1, 2021 13:03
@risicle risicle requested review from FRidh and jonringer as code owners June 1, 2021 13:03
@risicle
Copy link
Contributor Author

risicle commented Jun 1, 2021

(package broken on macos due to uvicorn)

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 1, 2021 •
edited
Loading

Result of nixpkgs-review pr 125213 at 3777863 run on x86_64-linux 1

8 packages built successfully:
  • datasette (python38Packages.datasette)
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.asgi-csrf
  • python38Packages.fastapi
  • python38Packages.starlette

Result of nixpkgs-review pr 125213 at 3777863 run on aarch64-linux 1

8 packages built successfully:
  • datasette (python38Packages.datasette)
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.asgi-csrf
  • python38Packages.fastapi
  • python38Packages.starlette

@risicle
Copy link
Contributor Author

risicle commented Jun 25, 2021

I'll take that as an approval ☝️

@risicle risicle merged commit 05b1f3f into NixOS:release-20.09 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wd15 wd15 Awaiting requested review from wd15

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@risicle @r-rmcgibbo