Skip to content

gnupg module: build custom pinentry for specified flavor only#125112

Closed
SCOTT-HAMILTON wants to merge 1 commit intoNixOS:masterfrom
SCOTT-HAMILTON:gnupg-pinentry
Closed

gnupg module: build custom pinentry for specified flavor only#125112
SCOTT-HAMILTON wants to merge 1 commit intoNixOS:masterfrom
SCOTT-HAMILTON:gnupg-pinentry

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Fixes #124753

Things done

option programs.gnupg.agent.pinentryFlavor will build a custom pinentry with only the needed flavor available as I think this was intented (and pinentry is quite quick to build anyway).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change cf the linked issue above
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

Pinging maintainers :

@fpletz @bkchr @shosti

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 31, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 31, 2021
@roberth
Copy link
Member

roberth commented Aug 8, 2021

It's not specific to this use of pinentry. All pinentry variants suffer from this kind of fragility. #133156

@fpletz
Copy link
Member

fpletz commented Aug 11, 2021

I think something like #133542 is the better fix for this issue.

@fpletz fpletz closed this Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation of pinentry with "curses" flavour fails with due to missing cairo-xlib package

3 participants