gnupg module: build custom pinentry for specified flavor only#125112
Closed
SCOTT-HAMILTON wants to merge 1 commit intoNixOS:masterfrom
Closed
gnupg module: build custom pinentry for specified flavor only#125112SCOTT-HAMILTON wants to merge 1 commit intoNixOS:masterfrom
SCOTT-HAMILTON wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
|
It's not specific to this use of pinentry. All pinentry variants suffer from this kind of fragility. #133156 |
Member
|
I think something like #133542 is the better fix for this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #124753
Things done
option
programs.gnupg.agent.pinentryFlavorwill build a custom pinentry with only the needed flavor available as I think this was intented (and pinentry is quite quick to build anyway).sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)Pinging maintainers :
@fpletz @bkchr @shosti