Skip to content

Conversation

@zhaofengli
Copy link
Member

Motivation for this change

This fixes the tests on RISC-V caused by floating point behavior differences (see linked upstream issue).
This only has an effect on native RISC-V builds (with #115406), but I guess it doesn't hurt to merge it now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

This fixes the tests on RISC-V caused by floating point behavior
differences (see linked upstream issue).
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 31, 2021
@Mic92 Mic92 merged commit 79f9745 into NixOS:master May 31, 2021
@zhaofengli zhaofengli deleted the libjpeg-riscv branch May 31, 2021 06:31
@zhaofengli zhaofengli mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants