Skip to content

libgudev: support cross-compilation by disabling introspection and vala #123936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtojnar merged 1 commit into from
May 23, 2021
Merged

libgudev: support cross-compilation by disabling introspection and vala #123936

jtojnar merged 1 commit into from
May 23, 2021

Conversation

@Mindavi
Copy link
Contributor

@Mindavi Mindavi commented May 21, 2021

Motivation for this change

Support cross-compilation for libgudev, a dependency of libwacom (which should support cross-compilation).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from amaxine, dasj19, edolstra, hedning and jtojnar May 21, 2021 22:16
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels May 21, 2021
jtojnar
jtojnar reviewed May 21, 2021
View reviewed changes
jtojnar
jtojnar reviewed May 21, 2021
View reviewed changes
@Mindavi Mindavi force-pushed the libgudev/cross-compilation branch from bc1f5dc to 7f6f24f Compare May 21, 2021 22:52
@ofborg ofborg bot requested a review from jtojnar May 21, 2021 23:01
jtojnar
jtojnar reviewed May 21, 2021
View reviewed changes
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 21, 2021

Result of nixpkgs-review pr 123936 at 7f6f24fa run on x86_64-linux 1

559 packages marked as broken and skipped:
  • aqemu
  • gimpPlugins.exposureBlend
  • gimpPlugins.texturize
  • glimpsePlugins.exposureBlend
  • glimpsePlugins.texturize
  • gnome.gnome-documents
  • goldendict
  • googleearth-pro
  • hplipWithPlugin_3_18_5
  • hplip_3_18_5
  • ...
2113 packages skipped due to time constraints:
  • AusweisApp2
  • OSCAR
  • Sylk
  • adapta-gtk-theme
  • adwaita-qt
  • ahoviewer
  • aj-snapshot
  • ajour
  • alarm-clock-applet
  • albert
  • ...
6 packages built successfully:
  • libgudev (gnome.libgudev)
  • libinput
  • libmanette
  • libmbim
  • libqmi
  • libwacom

@Mindavi Mindavi force-pushed the libgudev/cross-compilation branch from 7f6f24f to 11e8839 Compare May 23, 2021 11:56
@Mindavi Mindavi requested a review from jtojnar May 23, 2021 11:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels May 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2021

Failed to rebase

@Mindavi Mindavi force-pushed the libgudev/cross-compilation branch from 11e8839 to 05aa688 Compare May 23, 2021 12:49
@Mindavi Mindavi changed the base branch from staging to master May 23, 2021 12:49
@jtojnar jtojnar merged commit bacd5a9 into NixOS:master May 23, 2021
@jtojnar
Copy link
Member

jtojnar commented May 23, 2021

Thanks.

@erdnaxe erdnaxe mentioned this pull request Jun 8, 2021
Merged
11 tasks
@Mindavi Mindavi added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jun 16, 2021
@Mindavi Mindavi deleted the libgudev/cross-compilation branch November 21, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

@amaxine amaxine Awaiting requested review from amaxine

@edolstra edolstra Awaiting requested review from edolstra

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mindavi @r-rmcgibbo @jtojnar