Skip to content

python3Packages.Nikola: fix build#123245

Merged
jonringer merged 2 commits intoNixOS:masterfrom
fabaff:fix-nikola
May 16, 2021
Merged

python3Packages.Nikola: fix build#123245
jonringer merged 2 commits intoNixOS:masterfrom
fabaff:fix-nikola

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented May 16, 2021

Motivation for this change

Fix build

  • Cleanup the inputs
  • Switch to pytestCheckHook
  • Add missing dependency

ZHF: #122042
Ref: https://hydra.nixos.org/build/142879981

CC @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners May 16, 2021 14:11
@fabaff
Copy link
Copy Markdown
Member Author

fabaff commented May 16, 2021

Result of nixpkgs-review pr 123245 run on x86_64-linux 1

4 packages built:
  • python38Packages.Nikola
  • python38Packages.hsluv
  • python39Packages.Nikola
  • python39Packages.hsluv

@ofborg ofborg Bot added the 8.has: package (new) This PR adds a new package label May 16, 2021
@ofborg ofborg Bot requested a review from jluttine May 16, 2021 14:20
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 16, 2021
@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented May 16, 2021 •
edited
Loading

Result of nixpkgs-review pr 123245 at abfd043 run on aarch64-linux 1

4 packages built successfully:
  • python38Packages.Nikola
  • python38Packages.hsluv
  • python39Packages.Nikola
  • python39Packages.hsluv

Result of nixpkgs-review pr 123245 at abfd043 run on x86_64-linux 1

4 packages built successfully:
  • python38Packages.Nikola
  • python38Packages.hsluv
  • python39Packages.Nikola
  • python39Packages.hsluv

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 16, 2021
@fabaff fabaff mentioned this pull request May 16, 2021
Merged
10 tasks
jonringer
jonringer approved these changes May 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123245 run on x86_64-linux 1

4 packages built:
  • python38Packages.Nikola
  • python38Packages.hsluv
  • python39Packages.Nikola
  • python39Packages.hsluv

@fabaff fabaff deleted the fix-nikola branch May 17, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jluttine jluttine Awaiting requested review from jluttine

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @r-rmcgibbo @jonringer