Skip to content

apparmor: fix profile building on darwin#123005

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
ju1m:apparmor
May 14, 2021
Merged

apparmor: fix profile building on darwin#123005
vcunat merged 1 commit intoNixOS:staging-nextfrom
ju1m:apparmor

Conversation

@ju1m
Copy link
Contributor

@ju1m ju1m commented May 14, 2021

Motivation for this change

See #101071 (comment)

Things done
  • Replace ˋinstallˋ by ˋmkdirˋ and ˋcatˋ.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 14, 2021
@ju1m ju1m mentioned this pull request May 14, 2021
Merged
18 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 14, 2021
@vcunat vcunat changed the base branch from staging to staging-next May 14, 2021 16:12
@vcunat
Copy link
Member

vcunat commented May 14, 2021

Looks good to me, but why not try some darwin build:
@ofborg build inetutils

@ofborg ofborg bot added 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 14, 2021
vcunat
vcunat approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vcunat vcunat merged commit 850880e into NixOS:staging-next May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

@astsmtl astsmtl Awaiting requested review from astsmtl

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@primeos primeos Awaiting requested review from primeos

@lheckemann lheckemann Awaiting requested review from lheckemann

@wizeman wizeman Awaiting requested review from wizeman

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ju1m @vcunat