python3Packages.fastapi: fix build#122457
Conversation
|
Result of 5 packages built successfully:
1 suggestion:
Result of 5 packages built successfully:
1 suggestion:
|
Let's give the author a few hours here. Also there is https://github.com/tiangolo/fastapi/releases/tag/0.64.0 (3 days ago), so even if we would go with the patch an update would be appropriate. |
There was a problem hiding this comment.
This is really strange.
There was a problem hiding this comment.
Did urllib3 somehow change in Python 3.9 in a way such that local networking doesn't work in the sandbox anymore?
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7ffff50a5f70>: Failed to establish a new connection: [Errno 111] Connection refused
cc @FRidh @jonringer
There was a problem hiding this comment.
Never mind, it works now. Though the test looks a little flaky:
https://github.com/bobbui/json-logging-python/blob/1e887ca1dc949893e1757d29dc8a1d75fccc8dd1/tests/smoketests/test_run_smoketest.py#L42-L55
AluisioASG
left a comment
There was a problem hiding this comment.
LGTM, save for the leftover pythonAtLeast.
Motivation for this change
fastapi/fastapi#2335 was merged.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)