Skip to content

python3Packages.ipydatawidgets: unbreak#122345

Merged
jonringer merged 1 commit intoNixOS:masterfrom
DavHau:zhf-ipydatawidgets
May 13, 2021
Merged

python3Packages.ipydatawidgets: unbreak#122345
jonringer merged 1 commit intoNixOS:masterfrom
DavHau:zhf-ipydatawidgets

Conversation

@DavHau
Copy link
Member

@DavHau DavHau commented May 9, 2021

ZHF: #122042

Package version has been bumped by: #117452

New version fails during setup requiring npm. It didn't seem trivial to get rid of the npm requirement.
Nothing depends on this package and last version worked fine, so I just downgraded the package. Is this allowed?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DavHau DavHau requested review from FRidh and jonringer as code owners May 9, 2021 13:43
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 9, 2021
@ofborg ofborg bot requested a review from bcdarwin May 9, 2021 13:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 9, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 9, 2021

Result of nixpkgs-review pr 122345 at 18cb82a run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.ipydatawidgets
  • python39Packages.ipydatawidgets

Result of nixpkgs-review pr 122345 at 18cb82a run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.ipydatawidgets
  • python39Packages.ipydatawidgets

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 122345 run on x86_64-linux 1

2 packages built:
  • python38Packages.ipydatawidgets
  • python39Packages.ipydatawidgets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants