Skip to content

python3Packages.flask-appbuilder: unbreak#122330

Merged
fabaff merged 1 commit intoNixOS:masterfrom
DavHau:zhf-flask-appbuilder
May 16, 2021
Merged

python3Packages.flask-appbuilder: unbreak#122330
fabaff merged 1 commit intoNixOS:masterfrom
DavHau:zhf-flask-appbuilder

Conversation

@DavHau
Copy link
Member

@DavHau DavHau commented May 9, 2021

ZHF: #122042

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DavHau DavHau requested review from FRidh and jonringer as code owners May 9, 2021 12:11
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 9, 2021
@ofborg ofborg bot requested a review from costrouc May 9, 2021 12:20
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 9, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 9, 2021

Result of nixpkgs-review pr 122330 at 725cdef3 run on x86_64-linux 1

1 package failed to build:
4 packages built successfully:
  • python38Packages.flask-appbuilder
  • python38Packages.prison
  • python39Packages.flask-appbuilder
  • python39Packages.prison
3 suggestions:
  • warning: unused-argument

    Unused argument: nose.
    Near pkgs/development/python-modules/flask-appbuilder/default.nix:4:3:

      |
    4 | , nose
      |   ^
    
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/python-modules/flask-appbuilder/default.nix:37:15:

       |
    37 |   patches = [ ./flask-jwt-extended-4.1-compat.patch ];
       |               ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/flask-appbuilder/default.nix:74:0:

       |
    74 |     description = "Simple and rapid application development framework, built on top of Flask";
       | ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 122330 at 725cdef3 run on aarch64-linux 1

1 package failed to build:
4 packages built successfully:
  • python38Packages.flask-appbuilder
  • python38Packages.prison
  • python39Packages.flask-appbuilder
  • python39Packages.prison
3 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/flask-appbuilder/default.nix:74:0:

       |
    74 |     description = "Simple and rapid application development framework, built on top of Flask";
       | ^
    
  • warning: unused-argument

    Unused argument: nose.
    Near pkgs/development/python-modules/flask-appbuilder/default.nix:4:3:

      |
    4 | , nose
      |   ^
    
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/python-modules/flask-appbuilder/default.nix:37:15:

       |
    37 |   patches = [ ./flask-jwt-extended-4.1-compat.patch ];
       |               ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@DavHau DavHau force-pushed the zhf-flask-appbuilder branch from 725cdef to 0c779a1 Compare May 11, 2021 06:38
@DavHau DavHau requested a review from fabaff May 11, 2021 07:07
@fabaff
Copy link
Member

fabaff commented May 11, 2021

Could you remove flask-jwt-extended-4.1-compat.patch from the commit?

@risicle
Copy link
Contributor

risicle commented May 12, 2021

nixpkgs-review happy for me, nixos x86_64 & macos 10.15

@DavHau DavHau force-pushed the zhf-flask-appbuilder branch from 0c779a1 to e7115b7 Compare May 15, 2021 19:27
@DavHau
Copy link
Member Author

DavHau commented May 15, 2021

patch removed

@fabaff
Copy link
Member

fabaff commented May 16, 2021

Result of nixpkgs-review pr 122330 run on x86_64-linux 1

1 package failed to build:
  • apache-airflow
4 packages built:
  • python38Packages.flask-appbuilder
  • python38Packages.prison
  • python39Packages.flask-appbuilder
  • python39Packages.prison

@fabaff fabaff merged commit 6adf079 into NixOS:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants