python3Packages.flask-appbuilder: unbreak

[DavHau]

ZHF: #122042

• bumped prison from 0.1.2 to 0.1.3
• included patch from upstream PR: fix: Upgrade flask_jwt_extended and PyJWT to the latest versions dpgaspar/Flask-AppBuilder#1610 (modified)
• limited the restrictions set in postPatch a bit more, to prevent accidental future breakages

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 122330 at 725cdef3 run on x86_64-linux 1

1 package failed to build:

• apache-airflow

4 packages built successfully:

• python38Packages.flask-appbuilder
• python38Packages.prison
• python39Packages.flask-appbuilder
• python39Packages.prison

3 suggestions:

• warning: unused-argument

  Unused argument: nose.
  Near pkgs/development/python-modules/flask-appbuilder/default.nix:4:3:

    |
  4 | , nose
    |   ^
  

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/development/python-modules/flask-appbuilder/default.nix:37:15:

     |
  37 |   patches = [ ./flask-jwt-extended-4.1-compat.patch ];
     |               ^
  

• warning: python-include-tests

  Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

  Near pkgs/development/python-modules/flask-appbuilder/default.nix:74:0:

     |
  74 |     description = "Simple and rapid application development framework, built on top of Flask";
     | ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

---

Result of nixpkgs-review pr 122330 at 725cdef3 run on aarch64-linux 1

1 package failed to build:

• apache-airflow

4 packages built successfully:

• python38Packages.flask-appbuilder
• python38Packages.prison
• python39Packages.flask-appbuilder
• python39Packages.prison

3 suggestions:

• warning: python-include-tests

  Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

  Near pkgs/development/python-modules/flask-appbuilder/default.nix:74:0:

     |
  74 |     description = "Simple and rapid application development framework, built on top of Flask";
     | ^
  

• warning: unused-argument

  Unused argument: nose.
  Near pkgs/development/python-modules/flask-appbuilder/default.nix:4:3:

    |
  4 | , nose
    |   ^
  

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/development/python-modules/flask-appbuilder/default.nix:37:15:

     |
  37 |   patches = [ ./flask-jwt-extended-4.1-compat.patch ];
     |               ^
  

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

[fabaff]

Could you remove flask-jwt-extended-4.1-compat.patch from the commit?

[risicle]

nixpkgs-review happy for me, nixos x86_64 & macos 10.15

[DavHau]

patch removed

[fabaff]

Result of nixpkgs-review pr 122330 run on x86_64-linux 1

1 package failed to build:

• apache-airflow

4 packages built:

• python38Packages.flask-appbuilder
• python38Packages.prison
• python39Packages.flask-appbuilder
• python39Packages.prison