Skip to content

secp256k1: (unstable-)2020-08-16 -> unstable-2021-06-06 #121707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Jun 12, 2021
Merged

secp256k1: (unstable-)2020-08-16 -> unstable-2021-06-06 #121707

SuperSandro2000 merged 1 commit into from
Jun 12, 2021

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented May 4, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from chris-martin May 4, 2021 15:50
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 4, 2021
@prusnak prusnak changed the title secp256k1: (unstable-)2020-08-16 -> unstable-2021-05-03 secp256k1: (unstable-)2020-08-16 -> unstable-2021-05-31 Jun 3, 2021
@prusnak prusnak force-pushed the secp256k1 branch 2 times, most recently from c287eb3 to 76d8ca8 Compare June 8, 2021 21:34
@prusnak prusnak changed the title secp256k1: (unstable-)2020-08-16 -> unstable-2021-05-31 secp256k1: (unstable-)2020-08-16 -> unstable-2021-06-06 Jun 8, 2021
@prusnak
secp256k1: (unstable-)2020-08-16 -> unstable-2021-06-06
b66975c 
- use sane defaults
- drop JNI option which is not available anymore bitcoin-core/secp256k1#682
@SuperSandro2000 SuperSandro2000 merged commit b07cf14 into NixOS:master Jun 12, 2021
@prusnak prusnak deleted the secp256k1 branch June 12, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-martin chris-martin Awaiting requested review from chris-martin

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prusnak @SuperSandro2000