CODEOWNERS: make sure all Haskell files are present#121567
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom May 3, 2021
Merged
Conversation
github-actions
bot
added
the
6.topic: policy discussion
cdepillabout
commented
May 3, 2021
Comment on lines
-56
to
+58
| - pkgs/top-level/haskell-packages.nix | ||
| - pkgs/test/haskell/**/* | ||
| - pkgs/top-level/haskell-packages.nix |
Member
Author
There was a problem hiding this comment.
I just resorted this in alphabetical order.
cdepillabout
commented
May 3, 2021
Comment on lines
-82
to
+87
| /pkgs/development/compilers/ghc @cdepillabout @sternenseemann @maralorn | ||
| /pkgs/development/haskell-modules @cdepillabout @sternenseemann @maralorn | ||
| /pkgs/test/haskell @cdepillabout @sternenseemann @maralorn | ||
| /doc/languages-frameworks/haskell.section.md @cdepillabout @sternenseemann @maralorn | ||
| /maintainers/scripts/haskell @cdepillabout @sternenseemann @maralorn | ||
| /pkgs/development/compilers/ghc @cdepillabout @sternenseemann @maralorn | ||
| /pkgs/development/haskell-modules @cdepillabout @sternenseemann @maralorn | ||
| /pkgs/test/haskell @cdepillabout @sternenseemann @maralorn | ||
| /pkgs/top-level/haskell-packages.nix @cdepillabout @sternenseemann @maralorn |
Member
Author
There was a problem hiding this comment.
The things that have been added are:
/doc/languages-frameworks/haskell.section.md/maintainers/scripts/haskell(which was added in add maintainer scripts for haskell package generation #121391)/pkgs/top-level/haskell-packages.nix
@sternenseemann @maralorn If either of you guys don't want to be in this list, let me know and I'll edit this PR.
ofborg
bot
added
10.rebuild-darwin: 0
sternenseemann
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This updates the CODEOWNERS and labeler files in order to make sure all Haskell-related files are present.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)