Skip to content

python3Packages.sanic-auth: fix tests#121279

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
AluisioASG:aasg/sanic-auth
Apr 30, 2021
Merged

python3Packages.sanic-auth: fix tests#121279
dotlambda merged 1 commit intoNixOS:masterfrom
AluisioASG:aasg/sanic-auth

Conversation

@AluisioASG
Copy link
Contributor

After #120881, packages using Sanic's app.test_client or app.asgi_client need to depend on sanic-testing as well.

cc @dotlambda

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

After NixOS#120881, packages using Sanic's `app.test_client` or
`app.asgi_client` need to depend on `sanic-testing` as well.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 30, 2021
@ofborg ofborg bot requested a review from arnoldfarkas April 30, 2021 14:37
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 30, 2021
@dotlambda dotlambda merged commit 0463f91 into NixOS:master Apr 30, 2021
@AluisioASG AluisioASG deleted the aasg/sanic-auth branch April 30, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants