Skip to content

python3Packages.pytest-helpers-namespace: add missing dependency#121122

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
austinbutler:fix-pytest-helpers-namespace
Apr 30, 2021
Merged

python3Packages.pytest-helpers-namespace: add missing dependency#121122
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
austinbutler:fix-pytest-helpers-namespace

Conversation

@austinbutler
Copy link
Member

@austinbutler austinbutler commented Apr 29, 2021

Motivation for this change

Found ocrmypdf was broken, I think by #117452 where pytest-helpers-namespace was upgraded but was missing a dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 29, 2021
@austinbutler austinbutler requested a review from Kiwi April 29, 2021 06:27
@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 121122 run on x86_64-linux 1

12 packages built:
  • img2pdf (python38Packages.img2pdf)
  • ocrmypdf
  • pdfarranger
  • python38Packages.pikepdf
  • python38Packages.pypiserver
  • python38Packages.pytest-helpers-namespace
  • python38Packages.setuptools-declarative-requirements
  • python39Packages.img2pdf
  • python39Packages.pikepdf
  • python39Packages.pypiserver
  • python39Packages.pytest-helpers-namespace
  • python39Packages.setuptools-declarative-requirements

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 29, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 29, 2021

Result of nixpkgs-review pr 121122 at 23aa18c2 run on aarch64-linux 1

12 packages built successfully:
  • img2pdf (python38Packages.img2pdf)
  • ocrmypdf
  • pdfarranger
  • python38Packages.pikepdf
  • python38Packages.pypiserver
  • python38Packages.pytest-helpers-namespace
  • python38Packages.setuptools-declarative-requirements
  • python39Packages.img2pdf
  • python39Packages.pikepdf
  • python39Packages.pypiserver
  • python39Packages.pytest-helpers-namespace
  • python39Packages.setuptools-declarative-requirements
4 suggestions:
  • warning: unused-argument

    Unused argument: fetchPypi.
    Near pkgs/development/python-modules/pypiserver/default.nix:1:23:

      |
    1 | { buildPythonPackage, fetchPypi, fetchFromGitHub, lib, passlib, pytestCheckHook
      |                       ^
    
  • warning: unused-argument

    Unused argument: setuptools.
    Near pkgs/development/python-modules/setuptools-declarative-requirements/default.nix:1:68:

      |
    1 | { buildPythonPackage, fetchPypi, lib, pypiserver, pytestCheckHook, setuptools
      |                                                                    ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/setuptools-declarative-requirements/default.nix:23:0:

       |
    23 |     description = "Declarative setuptools Config Requirements Files Support";
       | ^
    
  • warning: unused-argument

    Unused argument: setuptools_scm.
    Near pkgs/development/python-modules/pypiserver/default.nix:2:31:

      |
    2 | , setuptools, setuptools-git, setuptools_scm, twine, webtest }:
      |                               ^
    

Result of nixpkgs-review pr 121122 at 23aa18c2 run on x86_64-linux 1

12 packages built successfully:
  • img2pdf (python38Packages.img2pdf)
  • ocrmypdf
  • pdfarranger
  • python38Packages.pikepdf
  • python38Packages.pypiserver
  • python38Packages.pytest-helpers-namespace
  • python38Packages.setuptools-declarative-requirements
  • python39Packages.img2pdf
  • python39Packages.pikepdf
  • python39Packages.pypiserver
  • python39Packages.pytest-helpers-namespace
  • python39Packages.setuptools-declarative-requirements
4 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/setuptools-declarative-requirements/default.nix:23:0:

       |
    23 |     description = "Declarative setuptools Config Requirements Files Support";
       | ^
    
  • warning: unused-argument

    Unused argument: setuptools_scm.
    Near pkgs/development/python-modules/pypiserver/default.nix:2:31:

      |
    2 | , setuptools, setuptools-git, setuptools_scm, twine, webtest }:
      |                               ^
    
  • warning: unused-argument

    Unused argument: setuptools.
    Near pkgs/development/python-modules/setuptools-declarative-requirements/default.nix:1:68:

      |
    1 | { buildPythonPackage, fetchPypi, lib, pypiserver, pytestCheckHook, setuptools
      |                                                                    ^
    
  • warning: unused-argument

    Unused argument: fetchPypi.
    Near pkgs/development/python-modules/pypiserver/default.nix:1:23:

      |
    1 | { buildPythonPackage, fetchPypi, fetchFromGitHub, lib, passlib, pytestCheckHook
      |                       ^
    

@austinbutler austinbutler force-pushed the fix-pytest-helpers-namespace branch from 23aa18c to dac63ca Compare April 29, 2021 16:59
@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 121122 run on x86_64-darwin 1

10 packages built:
  • img2pdf (python38Packages.img2pdf)
  • python38Packages.pikepdf
  • python38Packages.pypiserver
  • python38Packages.pytest-helpers-namespace
  • python38Packages.setuptools-declarative-requirements
  • python39Packages.img2pdf
  • python39Packages.pikepdf
  • python39Packages.pypiserver
  • python39Packages.pytest-helpers-namespace
  • python39Packages.setuptools-declarative-requirements

@austinbutler austinbutler force-pushed the fix-pytest-helpers-namespace branch from a5c38be to 3c55455 Compare April 30, 2021 01:18
@mweinelt
Copy link
Member

Looks pretty good otherwise!

@austinbutler austinbutler force-pushed the fix-pytest-helpers-namespace branch from 3c55455 to 15b1161 Compare April 30, 2021 02:34
@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 121122 run on x86_64-linux 1

12 packages built:
  • img2pdf (python38Packages.img2pdf)
  • ocrmypdf
  • pdfarranger
  • python38Packages.pikepdf
  • python38Packages.pypiserver
  • python38Packages.pytest-helpers-namespace
  • python38Packages.setuptools-declarative-requirements
  • python39Packages.img2pdf
  • python39Packages.pikepdf
  • python39Packages.pypiserver
  • python39Packages.pytest-helpers-namespace
  • python39Packages.setuptools-declarative-requirements

@SuperSandro2000 SuperSandro2000 merged commit d15fad3 into NixOS:master Apr 30, 2021
@austinbutler austinbutler deleted the fix-pytest-helpers-namespace branch May 24, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants