Skip to content

dyndnsc: 0.5.1 -> 0.6.1#120447

Merged
dotlambda merged 3 commits intoNixOS:masterfrom
AluisioASG:aasg/dyndnsc-0.6.1
Apr 30, 2021
Merged

dyndnsc: 0.5.1 -> 0.6.1#120447
dotlambda merged 3 commits intoNixOS:masterfrom
AluisioASG:aasg/dyndnsc-0.6.1

Conversation

@AluisioASG
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 23, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 23, 2021

Result of nixpkgs-review pr 120447 at d320b43f run on aarch64-linux 1

5 packages built successfully:
  • dyndnsc
  • python38Packages.json-logging
  • python38Packages.pytest-console-scripts
  • python39Packages.json-logging
  • python39Packages.pytest-console-scripts
2 suggestions:
  • warning: unused-argument

    Unused argument: fastapi.
    Near pkgs/development/python-modules/json-logging/default.nix:10:3:

       |
    10 | , fastapi
       |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/python-modules/json-logging/default.nix:26:5:

       |
    26 |     (fetchpatch {
       |     ^
    

Result of nixpkgs-review pr 120447 at d320b43f run on x86_64-linux 1

5 packages built successfully:
  • dyndnsc
  • python38Packages.json-logging
  • python38Packages.pytest-console-scripts
  • python39Packages.json-logging
  • python39Packages.pytest-console-scripts
2 suggestions:
  • warning: unused-argument

    Unused argument: fastapi.
    Near pkgs/development/python-modules/json-logging/default.nix:10:3:

       |
    10 | , fastapi
       |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/development/python-modules/json-logging/default.nix:26:5:

       |
    26 |     (fetchpatch {
       |     ^
    

@AluisioASG AluisioASG force-pushed the aasg/dyndnsc-0.6.1 branch 2 times, most recently from 7949c8a to 1c18e74 Compare April 26, 2021 21:23
@AluisioASG
Copy link
Contributor Author

Updated pytest-console-scripts to 1.2.0 but got hit by a broken dependency during rebase.

@dotlambda
Copy link
Member

python3Packages.openapi-spec-validator and python3Packages.sanic fail to build
cc @rvl @costrouc

@AluisioASG
Copy link
Contributor Author

openapi-spec-validator is fixed at #120793. sanic needs a bunch of fixes after being updated to 21.3, I'm working on it.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can only test after #120881 is merged.

@SuperSandro2000
Copy link
Member

@ofborg build dyndnsc

@SuperSandro2000
Copy link
Member

@AluisioASG I think connexion broke in the last week or so. Can you fix it so that we can check if dyndnsc still builds?

@AluisioASG
Copy link
Contributor Author

@AluisioASG I think connexion broke in the last week or so. Can you fix it so that we can check if dyndnsc still builds?

@SuperSandro2000 it's incompatible with the currently packaged version of openapi-spec-validator (spec-first/connexion#1343). To fix it for the entirety of Nixpkgs we'd probably have to package a openapi-spec-validator_0_29 just for it.

However, in dyndnsc's case we can just disable the tests that use it in json-logging. We already do that with FastAPI, which is similarly broken (#112701 (comment)) and I only don't suggest doing the same with Sanic because #120881 is well underway.

@dotlambda
Copy link
Member

@ofborg eval

@AluisioASG
Copy link
Contributor Author

Rebased and built locally. Turns out there are no tests using connexion so we can just drop it from dependencies.

@dotlambda dotlambda merged commit c8dff32 into NixOS:master Apr 30, 2021
@AluisioASG AluisioASG deleted the aasg/dyndnsc-0.6.1 branch April 30, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants