Skip to content

netbeans: Enable antialiasing for texts in NetBeans IDE#119817

Merged
kevincox merged 1 commit intoNixOS:masterfrom
asbachb:enable-anatialising-netbeans
Apr 18, 2021
Merged

netbeans: Enable antialiasing for texts in NetBeans IDE#119817
kevincox merged 1 commit intoNixOS:masterfrom
asbachb:enable-anatialising-netbeans

Conversation

@asbachb
Copy link
Contributor

@asbachb asbachb commented Apr 18, 2021

Motivation for this change

Previously anti antialiasing was disabled which makes it harder to read the entire IDE. This change enables anti aliasing for

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixo-t14s  ~/dev/src/nix/nixpkgs   enable-anatialising-netbeans  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (3.00 MiB download, 14.20 MiB unpacked):
  /nix/store/14cb3i39hz9pjslk7wfr82bvilgdl2rx-nixpkgs-review-2.5.0
  /nix/store/629aa8phfs5pc1sqda27sa0yf3750r0q-nix-2.4pre20210326_dd77f71
  /nix/store/a1ydkn0b99wbxvlvs6wcmgwkvq51bkfq-libcpuid-0.5.1
  /nix/store/k51bp7462c4xdhyfq0ph69xqmp2r50ig-lowdown-0.8.3-lib
  /nix/store/x6swbw1rr96mfpzn4ap552vqxl5ywvc2-nix-2.4pre20210326_dd77f71-man
copying path '/nix/store/x6swbw1rr96mfpzn4ap552vqxl5ywvc2-nix-2.4pre20210326_dd77f71-man' from 'https://cache.nixos.org'...
copying path '/nix/store/a1ydkn0b99wbxvlvs6wcmgwkvq51bkfq-libcpuid-0.5.1' from 'https://cache.nixos.org'...
copying path '/nix/store/k51bp7462c4xdhyfq0ph69xqmp2r50ig-lowdown-0.8.3-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/629aa8phfs5pc1sqda27sa0yf3750r0q-nix-2.4pre20210326_dd77f71' from 'https://cache.nixos.org'...
copying path '/nix/store/14cb3i39hz9pjslk7wfr82bvilgdl2rx-nixpkgs-review-2.5.0' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 54, done.
remote: Counting objects: 100% (53/53), done.
remote: Compressing objects: 100% (38/38), done.
remote: Total 54 (delta 23), reused 26 (delta 13), pack-reused 1
Unpacking objects: 100% (54/54), 242.23 KiB | 363.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   e3597057e72..fd6370f9e7c  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-a68d6172b810405a90e9605cef60263a186c7f84-dirty/nixpkgs fd6370f9e7c5badc10dea5597ae34409c7396610
Preparing worktree (detached HEAD fd6370f9e7c)
Updating files: 100% (25458/25458), done.
HEAD is now at fd6370f9e7c Merge pull request #119774 from Hoverbear/languageclient-neovim-0.1.161
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-a68d6172b810405a90e9605cef60263a186c7f84-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asbachb asbachb changed the title netbeans: Enable antialising for texts in NetBeans IDE netbeans: Enable antialiasing for texts in NetBeans IDE Apr 18, 2021
@asbachb asbachb force-pushed the enable-anatialising-netbeans branch from 6bfc9c7 to a68d617 Compare April 18, 2021 17:29
@ofborg ofborg bot requested review from rszibele and svanderburg April 18, 2021 17:38
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 18, 2021
@asbachb
Copy link
Contributor Author

asbachb commented Apr 18, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Apr 18, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Apr 18, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from kevincox April 18, 2021 18:39
@kevincox kevincox merged commit 9162925 into NixOS:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants