Skip to content

more Mac-friendly gnuplot#1197

Closed
kowey wants to merge 2 commits intoNixOS:masterfrom
kowey:kowey-octave2
Closed

more Mac-friendly gnuplot#1197
kowey wants to merge 2 commits intoNixOS:masterfrom
kowey:kowey-octave2

Conversation

@kowey
Copy link
Contributor

@kowey kowey commented Nov 10, 2013

No description provided.

This keeps the dependencies lighter. Perhaps future work on this
derivation could enable the Cocoa interface by default on Mac.
This variant uses the more Mac-friendly aqua driver, but it requires
that you separately install the AquaTerm package.

Note that AquaTerm is open source and could perhaps be later included
as a nix derivation. If that happens, it would be nice to remove the
gnuplot_aquaterm top-level attribute and just make it the default.
@vcunat
Copy link
Member

vcunat commented Nov 10, 2013

How will gnuplot know to use aquaterm? I see no option-passing, or any additional buildInput...

@kowey
Copy link
Contributor Author

kowey commented Nov 11, 2013

It looks like a default

On Sunday, 10 November 2013, Vladimír Čunát wrote:

How will gnuplot know to use aquaterm? I see no option-passing, or any
additional buildInput...


Reply to this email directly or view it on GitHubhttps://github.com//pull/1197#issuecomment-28160868
.

Eric Kow http://erickow.com

@vcunat
Copy link
Member

vcunat commented Nov 11, 2013

Hmm, so then people will automagically get different versions of gnuplot from the same derivation, based on whether the builder was run on a machine with aquaterm. I know we do have impurities in darwin, but this seems it could cause problems.

If there is a configure option available for it, IMO we would better make sure the build fails if the requested stuff isn't available, or something. People here expect to get (almost) the same thing when building the same thing on another machine. (It almost looks like we're trying to stop your contributions, but that's certainly not intentional.)

@kowey
Copy link
Contributor Author

kowey commented Nov 16, 2013

No problem at all :-) I appreciate Nix trying to be as predictable/pure as possible. Won't be able to look into this for quite a while.

Completely random note: it might be quite nice to distinguish different versions of MacOS from each other, even if the only consequence is getting a different hash for package config deps. At least, so long as things remain impure on darwin.

vcunat pushed a commit that referenced this pull request Dec 10, 2013
With minor changes from @vcunat, see #1197.
vcunat added a commit that referenced this pull request Dec 10, 2013
@vcunat
Copy link
Member

vcunat commented Dec 10, 2013

I did the change I meant and pushed into x-updates, very soon into master now, I hope.

@vcunat vcunat closed this Dec 10, 2013
@kowey
Copy link
Contributor Author

kowey commented Dec 10, 2013

Thanks! Sorry I never got around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants