oh-my-git: init at 0.6.4#119642
Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom Apr 19, 2021
Merged
Conversation
|
Result of 2 packages built successfully:
|
Member
|
Result of 2 packages built:
|
davidak
suggested changes
Apr 18, 2021
Member
There was a problem hiding this comment.
Thanks for creating the packages! ✨
You should add git as runtime dependency. Someone who plays this game to learn git might not have it installed already.
tested with:
[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ nix-shell -p --pure
[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ git
The program 'git' is not in your PATH. It is provided by several packages.
You can make it available in an ephemeral shell by typing one of the following:
nix-shell -p git
nix-shell -p git-doc
nix-shell -p gitMinimal
nix-shell -p gitSVN
[nix-shell:~/.cache/nixpkgs-review/pr-119642]$ results/oh-my-git/bin/oh-my-git
Change looks otherwise good.
Builds and works. Even finds my previous savegame :)
Member
|
Result of 2 packages built:
|
Member
|
@SuperSandro2000 do you want to add a second review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation for this change
Add the package for @davidak's package request. Closes #112341. I played about half of the levels and there seem to be no problems running the game.
The godot export commands expects a copy of the godot export templates at
$HOME/.local/share/godot/templates/3.2.3.stable/.... First i downloaded the zip archive from https://godotengine.org/download and copied the templates to the expected location. But the version of these export templates and the godot compiler need to be in sync.Therefore i added
godot-export-templatesbased on theheadless/serverpackage. Now the version of godot and the export templates are automatically in sync.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)